Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220521000921.8337-1-ruijian63@gmail.com>
In-Reply-To: <20220521000921.8337-1-ruijian63@gmail.com>
From:   Andrii Nakryiko <andrii.nakryiko@gmail.com>
Date:   Mon, 23 May 2022 12:39:41 -0700
Message-ID: <CAEf4BzZkfc4ivfewD4Bo8ngfcg-evOjYPwyyL1zcc3oH7rUDyQ@mail.gmail.com>
Subject: Re: [PATCH] samples: fix compile failure error
To:     Ruijian Li <ruijian63@gmail.com>
Cc:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>, Martin Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
        john fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>, 798073189@qq.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, May 20, 2022 at 5:09 PM Ruijian Li <ruijian63@gmail.com> wrote:
>
> Because compile samples/bpf/test_lru_dist failure, I remove the
> declaration of the struct list_head.
>
> Signed-off-by: Ruijian Li <ruijian63@gmail.com>
> ---
>  samples/bpf/test_lru_dist.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/samples/bpf/test_lru_dist.c b/samples/bpf/test_lru_dist.c
> index 75e877853596..dd7eb470653b 100644
> --- a/samples/bpf/test_lru_dist.c
> +++ b/samples/bpf/test_lru_dist.c
> @@ -33,10 +33,6 @@ static int nr_cpus;
>  static unsigned long long *dist_keys;
>  static unsigned int dist_key_counts;
>
> -struct list_head {
> -       struct list_head *next, *prev;
> -};
> -

this struct is used right there one line below, how removing it fixes
compilation issues? What was the error in the first place? Did you run
`make headers_install` before building samples/bpf? Please provide a
bit more information.

>  static inline void INIT_LIST_HEAD(struct list_head *list)
>  {
>         list->next = list;
> --
> 2.32.0
>