Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5caac943-5435-8603-9e84-a4da3792df1b@vivier.eu>
Date:   Mon, 23 May 2022 22:10:31 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH next] m68k: virt: Switch to new sys-off handler API
Content-Language: fr
To:     Geert Uytterhoeven <geert@linux-m68k.org>,
        Dmitry Osipenko <dmitry.osipenko@collabora.com>,
        "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>
Cc:     Stephen Rothwell <sfr@canb.auug.org.au>,
        linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org,
        noreply@ellerman.id.au
References: <20220523175520.949681-1-geert@linux-m68k.org>
From:   Laurent Vivier <laurent@vivier.eu>
In-Reply-To: <20220523175520.949681-1-geert@linux-m68k.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Le 23/05/2022 à 19:55, Geert Uytterhoeven a écrit :
> On m68k with CONFIG_VIRT=y (e.g. virt_defconfig or allmodconfig):
> 
>      arch/m68k/virt/config.c: In function ‘config_virt’:
>      arch/m68k/virt/config.c:129:2: error: ‘mach_power_off’ undeclared (first use in this function); did you mean ‘pm_power_off’?
>        129 |  mach_power_off = virt_halt;
> 	  |  ^~~~~~~~~~~~~~
> 	  |  pm_power_off
> 
> Commit 05d51e42df06f021 ("m68k: Introduce a virtual m68k machine")
> introduced a new user of mach_power_off.
> Convert it to the new sys-off handler API, too.
> 
> Reported-by: noreply@ellerman.id.au
> Fixes: f0f7e5265b3b37b0 ("m68k: Switch to new sys-off handler API")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
>   arch/m68k/virt/config.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/m68k/virt/config.c b/arch/m68k/virt/config.c
> index 68d29c8b87e18840..632ba200ad425245 100644
> --- a/arch/m68k/virt/config.c
> +++ b/arch/m68k/virt/config.c
> @@ -1,5 +1,6 @@
>   // SPDX-License-Identifier: GPL-2.0
>   
> +#include <linux/reboot.h>
>   #include <linux/serial_core.h>
>   #include <clocksource/timer-goldfish.h>
>   
> @@ -126,5 +127,6 @@ void __init config_virt(void)
>   	mach_get_model = virt_get_model;
>   	mach_reset = virt_reset;
>   	mach_halt = virt_halt;
> -	mach_power_off = virt_halt;
> +
> +	register_platform_power_off(virt_halt);
>   }


Reviewed-by: Laurent Vivier <laurent@vivier.eu>