Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp2278074ioo; Mon, 23 May 2022 14:39:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxfONPCu4z3g6+h2EdUOZOm4NXSDC7tJizdjt4J1HgF7PD7PNE5ip7CAyC/jm64inMz/ONp X-Received: by 2002:a17:902:76cb:b0:15e:f795:bf5e with SMTP id j11-20020a17090276cb00b0015ef795bf5emr24518659plt.39.1653341962072; Mon, 23 May 2022 14:39:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653341962; cv=none; d=google.com; s=arc-20160816; b=qjC8u3iNeDfnpm5KoUmv4K40ZaCVuv3U7WuHYZnHwId0f3YUYPYVKtQEWMicHPU+wM Ehf5qBDf+rnrAxo273U5DhTm3t5QTHuc3kfUhWg1BlAs3S/+NiMqIEtmFaZtOhgKhotl MkIL6yBZFZx9LfS0rB/SzMUS2AOllwUjiOD6/3ZFopAnXejImVteIaGC4IasDhXixkhZ CNxVPfOAvnz14H6qAeC64IwarlrR9idNFyehwToqQymRPu0XcJ7ix+NMmPxxNfpVLWKD CMDDtir3zt5NxcqF3E5i5y9zAgujy3fSbDHaIWSL4JMR+t9h85IpKPE8K6W38ebCO+EJ Hc7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:references :cc:to:from:content-language:subject:user-agent:mime-version:date :message-id:dkim-signature; bh=8nlcPdUIGG2cVtX3RxOVUlvfsw4FPYq0A3k29gmR/pU=; b=TrSYh9RE7RhbId3TTXICYSlL/eqyxgmsk3PwTtsllm7Kugag3OIR4loKb/b6efrx2u GFsk9ubtItgS1UGlKggDuMMDI1b7lCmxrY9ryKJFzpmf8RXzQgcihFlxBpRNFvtvGqDN BUme+/4/Eyfj5TlnanT9ytGQ5KyDO5y3cJhi5fbbQMZEGIr5sOcg/tXtK7v/OlHInF1s l/W41KZSPgUWRYS6O37v6O8keLwQFzqzv7Fdjeg/ERzr0OKBPWyX00idyLpQ8eEqVXqx KiZhiQWFji+fPPPs/DGyOXIr5ieLGjU+Z8iOW61T7vJ7MHshhO7M0thQIQQbuaFiLHlx zE/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=T3D6yNJ3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 73-20020a63034c000000b003fa5b55d8b9si5334228pgd.691.2022.05.23.14.39.11; Mon, 23 May 2022 14:39:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=T3D6yNJ3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232182AbiEWUFl (ORCPT + 99 others); Mon, 23 May 2022 16:05:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232169AbiEWUFi (ORCPT ); Mon, 23 May 2022 16:05:38 -0400 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 544CF8BD21 for ; Mon, 23 May 2022 13:05:34 -0700 (PDT) Received: by mail-pj1-x102d.google.com with SMTP id ob14-20020a17090b390e00b001dff2a43f8cso347191pjb.1 for ; Mon, 23 May 2022 13:05:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language :from:to:cc:references:in-reply-to:content-transfer-encoding; bh=8nlcPdUIGG2cVtX3RxOVUlvfsw4FPYq0A3k29gmR/pU=; b=T3D6yNJ37K7Afl1Tb0B+iS0pzL7eDNFeRj1lcKNj7dh/uPFFOGQYZBflz3r330WMWs v8zJ4tt9zPGQDeMAWnS0eTaXNEQJ118SPRLPlFw5jOC3o9BxPhQyXmenCcMYwrqCk2A3 VePb6xiEgrKUqTVZbz0hLT80m/T/zqgLZ9FzW83kyK30815NArQk5bH2PQdH0vuymT/z 1wSIVhACFrJX5tdCStlbpXHi2ueWtTfw1i3i5YoxoSXC7agx/x5c+dft9Zn+qRwQOO1C uzoPfjwKuB8LB+fp9jViGOvgCmVs8+svbJ/Q/DTIRlP89GJl6ptr1wNCMhfSLqELJ+OL t80A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=8nlcPdUIGG2cVtX3RxOVUlvfsw4FPYq0A3k29gmR/pU=; b=5Ni0h+kCXyvsju++4qP/MZ7ykg7UxP85o6o1RnSNgSPpJ5QVgCW7ouNQoJof+zYMrW Umhu5HOj2kH+DbqqZFgehrzb6htRP6UXQzs0De4t5WZU5Fz2MeTPG5iAGkh1g0h0IzLU Fr8OV7JGHwemfP8TsYZ70bhQastGQCBahmvJnCxdf0wNPFifYA1MIZKkG3Jh1cBslmyc V5GZsKQgJKcXVwgRYL/s3gyJ/KxqQXv8EJSUcY/7oC8Tne48wdaHEjaRDxFz/gDT6REF aIDne9QylZNfplEWFF5xCrRzc5kcMwo0dpetAYQr5lIQfUJ2+hPIQMqLvtZ6sOEJdgGY hSjQ== X-Gm-Message-State: AOAM533MiK80IFLJPN+WySY8NWow7A4+HORlZAshQvQCpqAdM0s45Nau srSTAlNR9+E4kaeUEAQ3DZ0xiA== X-Received: by 2002:a17:90a:cc6:b0:1d2:9a04:d29e with SMTP id 6-20020a17090a0cc600b001d29a04d29emr679619pjt.136.1653336333432; Mon, 23 May 2022 13:05:33 -0700 (PDT) Received: from [192.168.254.17] ([50.39.160.154]) by smtp.gmail.com with ESMTPSA id ge10-20020a17090b0e0a00b001d75aabe050sm83853pjb.34.2022.05.23.13.05.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 May 2022 13:05:32 -0700 (PDT) Message-ID: Date: Mon, 23 May 2022 13:05:31 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] cgroup: don't queue css_release_work if one already pending Content-Language: en-US From: Tadeusz Struk To: Tejun Heo Cc: =?UTF-8?Q?Michal_Koutn=c3=bd?= , Hillf Danton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzbot+e42ae441c3b10acf9e9d@syzkaller.appspotmail.com References: <20220412192459.227740-1-tadeusz.struk@linaro.org> <20220414164409.GA5404@blackbody.suse.cz> <20220422100400.GA29552@blackbody.suse.cz> <20220519112319.2455-1-hdanton@sina.com> <25fb057a-077f-b601-dcb7-130071c733db@linaro.org> <489592f6-b783-7bdb-2cc8-0c8e35ebc674@linaro.org> <20220520164255.GB17335@blackbody.suse.cz> <6ac66e89-2063-c5e8-df15-f77b76befc05@linaro.org> <7bbf2792-355b-65a7-e239-879b3f928384@linaro.org> In-Reply-To: <7bbf2792-355b-65a7-e239-879b3f928384@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/23/22 12:08, Tadeusz Struk wrote: > On 5/23/22 12:02, Tejun Heo wrote: >> Can you try holding an extra ref in the killed path? > > Yes, I can try that. Should that be with or without the extra work_struct? With this patch: https://syzkaller.appspot.com/text?tag=Patch&x=1264b23df00000 The issue still triggers: https://syzkaller.appspot.com/text?tag=CrashReport&x=162b5781f00000 -- Thanks, Tadeusz