Date: Wed, 16 May 2007 13:25:58 +0200
From: Jens Axboe <jens.axboe@oracle.com>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/19] scsi: convert to using sg helpers
Message-ID: <20070516112558.GQ23798@kernel.dk>
References: <11793043533744-git-send-email-jens.axboe@oracle.com> <11793043541476-git-send-email-jens.axboe@oracle.com> <20070516131720.4f9ed32a@gondolin.boeblingen.de.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20070516131720.4f9ed32a@gondolin.boeblingen.de.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1313
Lines: 41

On Wed, May 16 2007, Cornelia Huck wrote:
> On Wed, 16 May 2007 10:32:19 +0200,
> Jens Axboe <jens.axboe@oracle.com> wrote:
> 
> > This converts the SCSI mid layer to using the sg helpers for looking up
> > sg elements, instead of doing it manually.
> > 
> > Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
> > ---
> >  drivers/scsi/scsi_lib.c |   20 +++++++++++---------
> >  1 files changed, 11 insertions(+), 9 deletions(-)
> 
> This needs to include linux/scatterlist.h (other architectures seem to
> pull this header in via other routes, but e.g. s390 doesn't).
> 
> ---
>  drivers/scsi/scsi_lib.c |    1 +
>  1 files changed, 1 insertion(+)
> 
> --- linux.orig/drivers/scsi/scsi_lib.c
> +++ linux/drivers/scsi/scsi_lib.c
> @@ -17,6 +17,7 @@
>  #include <linux/pci.h>
>  #include <linux/delay.h>
>  #include <linux/hardirq.h>
> +#include <linux/scatterlist.h>
>  
>  #include <scsi/scsi.h>
>  #include <scsi/scsi_cmnd.h>

Patch 17 does that, so the end result should work. But I'll move it to
patch 5, that is the correct spot to do it. Thanks!

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/