Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762127AbXEPLjv (ORCPT ); Wed, 16 May 2007 07:39:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758841AbXEPLjn (ORCPT ); Wed, 16 May 2007 07:39:43 -0400 Received: from lazybastard.de ([212.112.238.170]:48278 "EHLO longford.lazybastard.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758328AbXEPLjm (ORCPT ); Wed, 16 May 2007 07:39:42 -0400 Date: Wed, 16 May 2007 13:35:20 +0200 From: =?utf-8?B?SsO2cm4=?= Engel To: Roland Dreier Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, akpm@osdl.org, Albert Cahalan , Thomas Gleixner , Jan Engelhardt , Evgeniy Polyakov , Pekka Enberg , Greg KH , Ingo Oeser Subject: Re: [PATCH] LogFS take three Message-ID: <20070516113519.GC5472@lazybastard.org> References: <20070515151919.GA32510@lazybastard.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1737 Lines: 51 On Tue, 15 May 2007 19:37:36 -0700, Roland Dreier wrote: > > There are rather a lot of of FIXME comments, including scary stuff like > > > + /* > > + * FIXME: this cannot be right but it does "fix" a bug of i_count > > + * dropping too low. Needs more thought. > > + */ > > + atomic_inc(&old_dentry->d_inode->i_count); Any thoughts on this would be appreciated. > and > > > +int __logfs_write_inode(struct inode *inode) > > +{ > > + /* > > + * FIXME: Those two inodes are 512 bytes in total. Not good to > > + * have on the stack. Possibly the best solution would be to bite > > + * the bullet and do another format change before release and > > + * shrink the inodes. > > + */ > > + struct logfs_disk_inode old, new; > > are you going to change the format? or fix this some other way? I would love to put my inodes on a diet. It is just a matter of time and priorities. To me the 512 bytes on the stack are unfortunate, but not a show stopper. Crash behaviour is, so that has priority. > I think a sweep through the code searching for FIXME and at least > rewriting all such comments to look like stuff that can be deferred > would be warranted ;) Are you asking me to hide known problems under a rug? ;) Will see if I can easily fix some of these. In particular the eat-your-data FIXME that can cause LogFS to not survive a crash. Jörn -- Correctness comes second. Features come third. Performance comes last. Maintainability is easily forgotten. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/