Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 24 May 2022 00:41:56 +0100
From:   Gary Guo <gary@garyguo.net>
To:     Nick Desaulniers <ndesaulniers@google.com>
Cc:     Miguel Ojeda <ojeda@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jarkko Sakkinen <jarkko@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Wedson Almeida Filho <wedsonaf@google.com>,
        Sven Van Asbroeck <thesven73@gmail.com>
Subject: Re: [PATCH v7 06/25] rust: add `compiler_builtins` crate
Message-ID: <20220524004156.0000790e@garyguo.net>
In-Reply-To: <CAKwvOd=mFhxjKRP_qt3Yu69dj_P6VUMSUSQm7fY6yS2bsO8Y2w@mail.gmail.com>
References: <20220523020209.11810-1-ojeda@kernel.org>
        <20220523020209.11810-7-ojeda@kernel.org>
        <CAKwvOd=mFhxjKRP_qt3Yu69dj_P6VUMSUSQm7fY6yS2bsO8Y2w@mail.gmail.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qovqBb3RwSBCPMu/TfVg7wJ2LPtAGkiLorTUCRR292Rdb8r5j42RrvW8mwBE?=
 =?us-ascii?Q?r2mA/P/VWL0yH8szLKD6VhRU7szrID2XsPO088ecbCSpPKsyOH4XbSSIxcnx?=
 =?us-ascii?Q?qauohg6a7CYP/seA6s+YdLWx5MCsBhDq4ZqBw10aoHzieZb3fbLU3/9YwfhK?=
 =?us-ascii?Q?jUp9S45zRQ2jiBEmlsg5XmWRJsqj2ei9jiiOIXVxKRjWLeF2xnIzX6lJ7XZt?=
 =?us-ascii?Q?jwclpn3MGW+vGxukWfLlC5oYOcNLveaQshRvfczJrue3KeGTRFZWK8BovBSH?=
 =?us-ascii?Q?lhLdVPs0kFnHLVUrDC9DUwz0G3LVuz35YAtW4RllVx7svba0TwzQKqS8PPZs?=
 =?us-ascii?Q?3A20HIAfqkqdoB/hU8HipiqO8FKhQ2kJmVsv5mRWfN+v8E26AriayJjIYR6/?=
 =?us-ascii?Q?e3f7F9P32IfPOjCJtqmc5dHR4sZR/nWxA+yTeNv0YFINvNRei4/pXNTHAvpu?=
 =?us-ascii?Q?umeV+Q6j6bZ7N/un1fY+tihOM5EXwg28jdpUNu2MVYCIvGGKLuRrI0Yr9CyY?=
 =?us-ascii?Q?a2mB550x/TfgasKHVaTA5nBw2hRdd7xafadxEBRClOo3QohqDZa9OvQ53rlF?=
 =?us-ascii?Q?i8+g9Hhjdixjw2Z9j5JtykzQeN+9zkqsgfr7duqBOIWdjw83ANy4gGnLP/id?=
 =?us-ascii?Q?qXG+hFAA7vC8rqNXc2X6L1j7zLk121LTMRKtCFSeqe3q8HCHxHucBEhSLVai?=
 =?us-ascii?Q?BDJwwQbXo80piUuL4OIi+1IDNBQUIagUyyAbLBMnEDg40mhDZ/vFigjdnnCJ?=
 =?us-ascii?Q?2DY5PLByw9peV2UUo0wLXHtZ3iRRB/2PbEkxRmskT5JKxaW7cMNmZ25lr/cp?=
 =?us-ascii?Q?GQL1lP6fP9XNpd0/MpienfHA3lX2sQXdUKOBG57o/srwMXK0U8fHFhNX6VCo?=
 =?us-ascii?Q?Md8T7jZQLLujTCGJVSTPvXpnN5mEJVdEsBzPSFYtwEMpMYdsAyOOxfMnIS61?=
 =?us-ascii?Q?rW6x9UKya0dvfH+sQlMCRyE6dkK8CCygvvCi6x6LlVk6wZdV/brCxO2u6514?=
 =?us-ascii?Q?RdxSYll03i/qQ9RSeGSON2F59KqumJJBA6gUTGyKgyqCm5hIs1uEKtQ13Whh?=
 =?us-ascii?Q?4QDnnWFVocOFD4hC2haZYZ7NzAqWyOPv5707MaHDZk01/wLvAguBLAuQG845?=
 =?us-ascii?Q?9t0oDNDDOhhUgbzGLNP3dGjINc/8fHakRzpmkvmwZj24u53qvHSGKZltsRQU?=
 =?us-ascii?Q?x14SyQNF/RIEJ43lyeWsFQ5qzIGa6RwE5pyv2fGDGo7+TOd8Hl62NEFkIpgL?=
 =?us-ascii?Q?40QbKf35aB8gIwMjmmVfqwsjl1kAiIN+lq1NsfSKUadEFcbI9wP21HmS/QRo?=
 =?us-ascii?Q?itfegVu7eZ8PSPkMWOxEd8MBakqLzoAUiXlYUY1s5DpcwJ8BB8v+77WBEXU2?=
 =?us-ascii?Q?PdNRT73LJLVRz2/F2ol7CWSiA1ctdXwt23xEhYd475jhMxU83PU1vNoMkVJ8?=
 =?us-ascii?Q?IP2nMgkXE1Awp//U839xUjAwmPwngQkOw+fIlJtN2NBmwny//4gZKBkwijBP?=
 =?us-ascii?Q?r76jYgQ/L9vpqu43IYe1KCeMRZsdELlx70dvcEaOH/sYlRbPEx31SDbjqCZy?=
 =?us-ascii?Q?XcYYmZtiLUvGsJRvARcvF6QeYVRw+nDm1iTN0m4Uo0GNp3ASuVDN1bfYzoNR?=
 =?us-ascii?Q?glV/W4w24cQgEz1q90JcL9FD7KTd96BSoqa322WKPQ/1tdgA0P1RsfYs2iWV?=
 =?us-ascii?Q?RQYncSd6yzt02CtK6K0hl3NHA9bbkx+V4+NaHUfhcSPGRjWJ5/uPwsYHXXUl?=
 =?us-ascii?Q?DYgo5jCzszztFj75fvK0q8xEdRbG9/bazefPDR2PyNHAUhtMrKwAEV29NPmx?=
X-MS-Exchange-AntiSpam-MessageData-1: pDGCgwcn7ZXY4A==
X-OriginatorOrg: garyguo.net
X-MS-Exchange-CrossTenant-Network-Message-Id: cce8d2d1-dfd0-4a54-ec82-08da3d15d603
X-MS-Exchange-CrossTenant-AuthSource: LO2P265MB5183.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2022 23:42:02.1640
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: e0bz3L9BwWO6xjxdXa+3yVm2AjgGRWfPqx7sSLeGic4UGbcPWPO38krKhBmHWhdadhANMJ7nImdbvaWz7osZFA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO2P265MB5774
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 23 May 2022 11:37:16 -0700
Nick Desaulniers <ndesaulniers@google.com> wrote:

> Also, I'm not sure my concern about explicit build failures for C code
> was ever addressed?  We have a constant problem with `long long`
> division on ARCH=arm32 and ARCH=i386 in C code.
> https://lore.kernel.org/lkml/CAKwvOdk+A2PBdjSFVUhj4xyCGCKujtej1uPgywQgrKPiK2ksPw@mail.gmail.com/
>
> > +#[cfg(target_arch = "arm")]
> > +define_panicking_intrinsics!("`u64` division/modulo should not be
> > used", {
> > +    __aeabi_uldivmod,
> > +    __mulodi4,
> > +});

Starting in LLVM 14 (used in Rust 1.60+), __mulodi4 will no longer be
generated. So that can be removed.

As for __aeabi_uldivmod, is there any reason that it can't just be
defined in arch/arm/lib? There are quite a few __aeabi functions already
defined there.

The source of __aeabi_uldivmod in compiler-rt seems quite simple, just
delegating to __uldivmoddi4. I think just changing that to
div64_u64_rem should do the job?

https://android.googlesource.com/toolchain/compiler-rt/+/release_32/lib/arm/aeabi_uldivmod.S

- Gary