Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <1653360644-28872-1-git-send-email-baihaowen@meizu.com>
In-Reply-To: <1653360644-28872-1-git-send-email-baihaowen@meizu.com>
From:   Huacai Chen <chenhuacai@kernel.org>
Date:   Tue, 24 May 2022 11:06:15 +0800
Message-ID: <CAAhV-H7Xw-LPdHg1mVF1aZ67RQACBP0kans+moZ3GaRb5PF6VA@mail.gmail.com>
Subject: Re: [PATCH] LoongArch: take size of pointed value, not pointer
To:     Haowen Bai <baihaowen@meizu.com>
Cc:     Ard Biesheuvel <ardb@kernel.org>,
        linux-efi <linux-efi@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi, Haowen,

On Tue, May 24, 2022 at 10:52 AM Haowen Bai <baihaowen@meizu.com> wrote:
>
> Sizeof a pointer-typed expression returns the size of the pointer, not
> that of the pointed data.
Your patch is correct, but the original patch hasn't been upstream, I don't
know how to handle it.

>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
>  arch/loongarch/kernel/efi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/loongarch/kernel/efi.c b/arch/loongarch/kernel/efi.c
> index f9fdeb1ae358..f0e5d0feffc2 100644
> --- a/arch/loongarch/kernel/efi.c
> +++ b/arch/loongarch/kernel/efi.c
> @@ -180,7 +180,7 @@ void __init efi_init(void)
>         if (!efi_system_table)
>                 return;
>
> -       efi_systab = (efi_system_table_t *)early_memremap_ro(efi_system_table, sizeof(efi_systab));
> +       efi_systab = (efi_system_table_t *)early_memremap_ro(efi_system_table, sizeof(*efi_systab));
>         if (!efi_systab) {
>                 pr_err("Can't find EFI system table.\n");
>                 return;
> --
> 2.7.4
>