Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vaibhav Jain <vaibhav@linux.ibm.com>
To:     Michael Ellerman <mpe@ellerman.id.au>,
        Rob Herring <robh@kernel.org>
Cc:     devicetree@vger.kernel.org, Frank Rowand <frowand.list@gmail.com>,
        linux-kernel@vger.kernel.org,
        Prakhar Srivastava <prsriva@linux.microsoft.com>,
        Lakshmi Ramasubramanian <nramas@linux.microsoft.com>,
        linuxppc-dev@lists.ozlabs.org,
        Thiago Jung Bauermann <bauerman@linux.ibm.com>
Subject: Re: [PATCH] powerpc: check previous kernel's ima-kexec-buffer
 against memory bounds
In-Reply-To: <87fsl0na5m.fsf@mpe.ellerman.id.au>
References: <20220518200547.655788-1-vaibhav@linux.ibm.com>
 <20220520223025.GA359803-robh@kernel.org>
 <87wnedfaey.fsf@vajain21.in.ibm.com> <87fsl0na5m.fsf@mpe.ellerman.id.au>
Date:   Tue, 24 May 2022 11:27:24 +0530
Message-ID: <87tu9ffp6j.fsf@vajain21.in.ibm.com>
Content-Type: text/plain
MIME-Version: 1.0
Precedence: bulk


Michael Ellerman <mpe@ellerman.id.au> writes:

<snip>
>
> Rob's point is that commit fee3ff99bc67 only moved existing code, the
> bug already existed.
>
> The function was introduced in:
>
>   467d27824920 ("powerpc: ima: get the kexec buffer passed by the previous kernel")
>
> So that's where the Fixes tag should point.

Thanks Mpe for explaining and apologies Rob as I initially didnt get the
point you made. I wrongly assumed that since the patch can only be
applied on top of commit fee3ff99bc67 hence fixes should point to
fee3ff99bc67.

I have sent out a v2 with the updated Fixes tag and also changes as
suggested by Mpe and Rob at
https://lore.kernel.org/all/20220524055042.1527968-1-vaibhav@linux.ibm.com/

-- 
Cheers
~ Vaibhav