Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762079AbXEPMVc (ORCPT ); Wed, 16 May 2007 08:21:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758437AbXEPMVY (ORCPT ); Wed, 16 May 2007 08:21:24 -0400 Received: from e34.co.us.ibm.com ([32.97.110.152]:41148 "EHLO e34.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758236AbXEPMVW (ORCPT ); Wed, 16 May 2007 08:21:22 -0400 Subject: Re: [PATCH 1/5][TAKE3] fallocate() implementation on i86, x86_64 and powerpc From: Dave Kleikamp To: David Chinner Cc: "Amit K. Arora" , torvalds@osdl.org, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org, xfs@oss.sgi.com, suparna@in.ibm.com, cmm@us.ibm.com In-Reply-To: <20070516031626.GM85884050@sgi.com> References: <20070330071417.GI355@devserv.devel.redhat.com> <20070417125514.GA7574@amitarora.in.ibm.com> <20070418130600.GW5967@schatzie.adilger.int> <20070420135146.GA21352@amitarora.in.ibm.com> <20070420145918.GY355@devserv.devel.redhat.com> <20070424121632.GA10136@amitarora.in.ibm.com> <20070426175056.GA25321@amitarora.in.ibm.com> <20070515193722.GA3487@amitarora.in.ibm.com> <20070515195421.GA2948@amitarora.in.ibm.com> <20070515200359.GA5834@amitarora.in.ibm.com> <20070516031626.GM85884050@sgi.com> Content-Type: text/plain Date: Wed, 16 May 2007 07:21:16 -0500 Message-Id: <1179318076.10313.6.camel@kleikamp.austin.ibm.com> Mime-Version: 1.0 X-Mailer: Evolution 2.8.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1549 Lines: 37 On Wed, 2007-05-16 at 13:16 +1000, David Chinner wrote: > On Wed, May 16, 2007 at 01:33:59AM +0530, Amit K. Arora wrote: > > Following changes were made to the previous version: > > 1) Added description before sys_fallocate() definition. > > 2) Return EINVAL for len<=0 (With new draft that Ulrich pointed to, > > posix_fallocate should return EINVAL for len <= 0. > > 3) Return EOPNOTSUPP if mode is not one of FA_ALLOCATE or FA_DEALLOCATE > > 4) Do not return ENODEV for dirs (let individual file systems decide if > > they want to support preallocation to directories or not. > > 5) Check for wrap through zero. > > 6) Update c/mtime if fallocate() succeeds. > > Please don't make this always happen. c/mtime updates should be dependent > on the mode being used and whether there is visible change to the file. If no > userspace visible changes to the file occurred, then timestamps should not > be changed. i_blocks will be updated, so it seems reasonable to update ctime. mtime shouldn't be changed, though, since the contents of the file will be unchanged. > e.g. FA_ALLOCATE that changes file size requires same semantics of ftruncate() > extending the file, otherwise no change in timestamps should occur. > > Cheers, > > Dave. -- David Kleikamp IBM Linux Technology Center - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/