Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <1653360644-28872-1-git-send-email-baihaowen@meizu.com>
 <CAAhV-H7Xw-LPdHg1mVF1aZ67RQACBP0kans+moZ3GaRb5PF6VA@mail.gmail.com>
 <CAAhV-H4Qcj9y6opY3WMTbE8myo77fYRb8Z42C+MPYuScz8N67g@mail.gmail.com> <CAAhV-H6tKeyeo3L7=C2NUQyw_cJpusWYmGUrm8LVVidvjB3MgQ@mail.gmail.com>
In-Reply-To: <CAAhV-H6tKeyeo3L7=C2NUQyw_cJpusWYmGUrm8LVVidvjB3MgQ@mail.gmail.com>
From:   Ard Biesheuvel <ardb@kernel.org>
Date:   Tue, 24 May 2022 14:11:33 +0200
Message-ID: <CAMj1kXEEjCNedgBqfLLXGTD1FgfoTSREMT8Xjn7Ec4_1twrNmg@mail.gmail.com>
Subject: Re: [PATCH] LoongArch: take size of pointed value, not pointer
To:     Huacai Chen <chenhuacai@kernel.org>
Cc:     Haowen Bai <baihaowen@meizu.com>,
        linux-efi <linux-efi@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, 24 May 2022 at 13:41, Huacai Chen <chenhuacai@kernel.org> wrote:
>
> Hi, Haowen,
>
> On Tue, May 24, 2022 at 12:03 PM Huacai Chen <chenhuacai@kernel.org> wrote:
> >
> > On Tue, May 24, 2022 at 11:06 AM Huacai Chen <chenhuacai@kernel.org> wrote:
> > >
> > > Hi, Haowen,
> > >
> > > On Tue, May 24, 2022 at 10:52 AM Haowen Bai <baihaowen@meizu.com> wrote:
> > > >
> > > > Sizeof a pointer-typed expression returns the size of the pointer, not
> > > > that of the pointed data.
> > > Your patch is correct, but the original patch hasn't been upstream, I don't
> > > know how to handle it.
> > I've squash your patch to the original one and add a Co-developed-by:,
> > not sure it is the best solution. Thanks.
> I was suggested that a "Suggested-by" is suitable.
> https://lore.kernel.org/lkml/CAAhV-H6k=xC-fDYnwsqSeoj7QPPn8RAcR+waQMa8yTs5J-XOSg@mail.gmail.com/T/#t
>

Finding and fixing mistakes is the normal review process, and not
every addressed comment needs to be reflected in the tags, even if the
contributor sent it as a separate patch. Adding 'Suggested-by' to the
entire patch falsely implies that the author of the bugfix suggested
the entire work, which is not desirable either.

In this case, the bugfix is a well-known anti-pattern which is not
specific to the introduced code. I don't think this warrants a tag
tbh.