Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp2824508ioo; Tue, 24 May 2022 06:51:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzYhK3jq52YPR2enj6FpJHIUIdRqCdFiDFTg55oII+/zDL2hzEvbWzsk5co24dO+mcqMLWs X-Received: by 2002:a17:907:6d12:b0:6fe:bef9:58d5 with SMTP id sa18-20020a1709076d1200b006febef958d5mr14390857ejc.548.1653400287992; Tue, 24 May 2022 06:51:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653400287; cv=none; d=google.com; s=arc-20160816; b=MzVQSWGfLinp4azqd41MFkQerTJLeX1FcPTtZx5V6zCpuwx3z2qYFakeFVyBiB/Tzh 8AAZr5qGqsPRUBGtmyQocKcFKhpfdeVRnckBYjhTVi5QhMLBKKdGYESk2dk3VNRcb8m/ 2lqlNtiWMdCklHs5EbpAL3DErqXlTrb4Y5u4stiCZxnS6TMernIhncf9cGRzWwUcgCoX dwlh6d1ZOCm6s9viVsDh/v1RZ1IgcfYTGBLKfBr8KWwvi3EP8b15y56tGtrvCsmt18Xb qZr7bC4C5XeB8/CwFrEhRanGTksUGnjLFPL5BaGuk3aq1VCqR5SGfq5IXrCrwiD/ALwx NBPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from; bh=VL9Y4gwr2dn/pKMIovGBra69aDA1cOwpJVdlr6m4DIA=; b=iU2ydpOlVtFT1SqT9XI/F9Kvl9DxBzqv2aeUd8IRO9WS6BJCuFJiSHPNGfZyB81qZT 05TzJV0XX6T79ortSkEvXiidpgxvwvUEaBe8pwqP3qstb3UlO8CEviBH5kyIE7+r9ebr eOk2WfH/XK1GTAXNWBZ9AnUROTKQ9XPgoWoVhvLs8Xz1iwdYoXxfnVQ+6LC/0SrA9KR3 YUZKJQPDdf5YJYYlKKdfrIIEhE712h9GmNhSPmFIVFbD37cGV62BErjDpjU0SFfNmdll RRCa6Dz5MIb6THAvH2L1dN9Dyqcpdc/N0cxM/y8mkYZ/8MN7WuTwuV3t1DpdOjBeti1t I6cQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w1-20020a05640234c100b0042b4dfdeac8si10821594edc.578.2022.05.24.06.51.01; Tue, 24 May 2022 06:51:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236586AbiEXLQ1 (ORCPT + 99 others); Tue, 24 May 2022 07:16:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236463AbiEXLPk (ORCPT ); Tue, 24 May 2022 07:15:40 -0400 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 349C69155E for ; Tue, 24 May 2022 04:15:39 -0700 (PDT) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4L6s7Y0nh8z4ySt; Tue, 24 May 2022 21:15:37 +1000 (AEST) From: Michael Ellerman To: Benjamin Herrenschmidt , Finn Thain Cc: linux-kernel@vger.kernel.org, Randy Dunlap , Christophe Leroy , Geert Uytterhoeven , linuxppc-dev@lists.ozlabs.org In-Reply-To: <5edbe76ce68227f71e09af4614cc4c1bd61c7ec8.1649326292.git.fthain@linux-m68k.org> References: <5edbe76ce68227f71e09af4614cc4c1bd61c7ec8.1649326292.git.fthain@linux-m68k.org> Subject: Re: [PATCH v2] macintosh/via-pmu: Fix build failure when CONFIG_INPUT is disabled Message-Id: <165339058086.1718562.16646756520470631496.b4-ty@ellerman.id.au> Date: Tue, 24 May 2022 21:09:40 +1000 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 07 Apr 2022 20:11:32 +1000, Finn Thain wrote: > drivers/macintosh/via-pmu-event.o: In function `via_pmu_event': > via-pmu-event.c:(.text+0x44): undefined reference to `input_event' > via-pmu-event.c:(.text+0x68): undefined reference to `input_event' > via-pmu-event.c:(.text+0x94): undefined reference to `input_event' > via-pmu-event.c:(.text+0xb8): undefined reference to `input_event' > drivers/macintosh/via-pmu-event.o: In function `via_pmu_event_init': > via-pmu-event.c:(.init.text+0x20): undefined reference to `input_allocate_device' > via-pmu-event.c:(.init.text+0xc4): undefined reference to `input_register_device' > via-pmu-event.c:(.init.text+0xd4): undefined reference to `input_free_device' > make[1]: *** [Makefile:1155: vmlinux] Error 1 > make: *** [Makefile:350: __build_one_by_one] Error 2 > > [...] Applied to powerpc/next. [1/1] macintosh/via-pmu: Fix build failure when CONFIG_INPUT is disabled https://git.kernel.org/powerpc/c/86ce436e30d86327c9f5260f718104ae7b21f506 cheers