Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1546297c-6627-574e-4b30-4b8dbf95a851@linaro.org>
Date:   Tue, 24 May 2022 11:20:05 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH 2/2] ARM: dts: imx: Add devicetree for Kobo Aura 2
Content-Language: en-US
To:     Andreas Kemnade <andreas@kemnade.info>
Cc:     robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        arnd@arndb.de, olof@lixom.net, soc@kernel.org, shawnguo@kernel.org,
        s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com,
        linux-imx@nxp.com, l.stach@pengutronix.de,
        alexander.stein@ew.tq-group.com, marcel.ziswiler@toradex.com,
        linux@rempel-privat.de, matthias.schiffer@ew.tq-group.com,
        cniedermaier@dh-electronics.com, sebastian.reichel@collabora.com,
        leoyang.li@nxp.com, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        nicolecrivain@gmail.com
References: <20220522214415.254959-1-andreas@kemnade.info>
 <20220522214415.254959-3-andreas@kemnade.info>
 <402c7e38-7ad0-581f-146d-3db88e77d37c@linaro.org>
 <20220523210542.0735dd5f@aktux>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20220523210542.0735dd5f@aktux>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 23/05/2022 21:05, Andreas Kemnade wrote:
> On Mon, 23 May 2022 12:03:09 +0200
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> 
> [...]
>>> +
>>> +	gpio_keys: gpio-keys {
>>> +		compatible = "gpio-keys";
>>> +		pinctrl-names = "default";
>>> +		pinctrl-0 = <&pinctrl_gpio_keys>;
>>> +
>>> +		cover {  
>>
>> Generic node names. You could add suffix if needed, so either key or
>> key-cover.
>>
> hmm, the example in
> Documentation/devicetree/bindings/input/gpio-keys.yaml
> 
> shows names like I did. I usually expect to trust binding documentation
> to have something acceptable.

It's only an example and no one usually cares about correcting it, once
it got merged.


Best regards,
Krzysztof