Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp2979831ioo; Tue, 24 May 2022 10:07:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzs4BPqnoz7RAT2BR+Cr9GDtRI/G/6MgBWKB8V1lPLASJ7PS+usEmCTjQirqucq9/E5JMSB X-Received: by 2002:a63:3c05:0:b0:3f2:6ea8:aff2 with SMTP id j5-20020a633c05000000b003f26ea8aff2mr25436756pga.340.1653412055846; Tue, 24 May 2022 10:07:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653412055; cv=none; d=google.com; s=arc-20160816; b=eqF0yGK9r8l1frrbM719ocKAkxuiEG5isV3YOFboPaNMPe/skSc1FAyhUzTwDa7H86 mhWwDA0lT7HTYTjuNkk/BQEHR46jXsKo/WTXihO3EvS+57KZbq8JU+vWR0aR41mzVbdm eQhzfsK6zIlhuytXhiOTi898PuNw5pjN6Rrmkj9lXN7/eFskHROJOjlIqRghf0CVh7P4 poFuXmKLeTveqbOROWZ910eKvML6RVmDqlV5hL+Ra2hr+93loen1Vv9MpzRdB+7wRSAc jFwsE0kBeYK8YdavAuo1TNow4TIYrmjd3aszpMe8J1o5VLu/HWCsvoUbl8aYWF91Yrsx TvAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=da5E8b5qWUUpqaodv8lHFCz3ufB5F0Ln/FwzskHrfSc=; b=Xzp434RsJmJb3ciGqAVSqV5hj+uwVB596kb/bUkUSfn6j1GUuzVdgN0pQDrWouZr6Y Z9FVsSJbqkGSCSSXKlsTFYSo1YMO90FM91FMl6TEC9A+Uilnd+M1A398OTlMBI5LwHWv OOIDxEwk0lPrKxMPHzmxoxYPbO9+hdI2OncjzjVSV1UrO+QXORXo3ArdO8IRWBnmlUNE N3tBmJpNCtBBh9ik138eXR7WAMZEwLSXJ+YsA92ElKl5fgzNGD8izNRmoVejEmzPjOex YIWer01OFlCapSMMmx67YHaOSwUvt6Aep/LH1pNYNZr9RcjyyIVq1h4VnCsf1Jp2olGZ MzIA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i37-20020a635425000000b003c24706f629si14951850pgb.75.2022.05.24.10.07.20; Tue, 24 May 2022 10:07:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234776AbiEXGJz (ORCPT + 99 others); Tue, 24 May 2022 02:09:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234755AbiEXGJw (ORCPT ); Tue, 24 May 2022 02:09:52 -0400 Received: from mail.meizu.com (edge07.meizu.com [112.91.151.210]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A835D6A07A; Mon, 23 May 2022 23:09:49 -0700 (PDT) Received: from IT-EXMB-1-125.meizu.com (172.16.1.125) by mz-mail11.meizu.com (172.16.1.15) with Microsoft SMTP Server (TLS) id 14.3.487.0; Tue, 24 May 2022 14:09:49 +0800 Received: from meizu.meizu.com (172.16.137.70) by IT-EXMB-1-125.meizu.com (172.16.1.125) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Tue, 24 May 2022 14:09:47 +0800 From: Haowen Bai To: Miquel Raynal , Alessandro Zummo , Alexandre Belloni , Michel Pollet CC: Haowen Bai , , , Subject: [PATCH] rtc: rzn1: Fix inconsistent IS_ERR and PTR_ERR Date: Tue, 24 May 2022 14:09:45 +0800 Message-ID: <1653372586-24736-1-git-send-email-baihaowen@meizu.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.16.137.70] X-ClientProxiedBy: IT-EXMB-1-126.meizu.com (172.16.1.126) To IT-EXMB-1-125.meizu.com (172.16.1.125) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The proper pointer to be passed as argument is rtc->rtcdev. Detected using Coccinelle. Fixes: deeb4b5393e1 ("rtc: rzn1: Add new RTC driver") Signed-off-by: Haowen Bai --- drivers/rtc/rtc-rzn1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index f92d1398b0f1..4cf54af8a8c3 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -348,7 +348,7 @@ static int rzn1_rtc_probe(struct platform_device *pdev) rtc->rtcdev = devm_rtc_allocate_device(&pdev->dev); if (IS_ERR(rtc->rtcdev)) - return PTR_ERR(rtc); + return PTR_ERR(rtc->rtcdev); rtc->rtcdev->range_min = RTC_TIMESTAMP_BEGIN_2000; rtc->rtcdev->range_max = RTC_TIMESTAMP_END_2099; -- 2.7.4