Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <195ae1109ca06c690f3fba7475e789180a328654.camel@redhat.com>
Subject: Re: [PATCH V3] octeon_ep: Remove unnecessary cast
From:   Paolo Abeni <pabeni@redhat.com>
To:     Haowen Bai <baihaowen@meizu.com>,
        Veerasenareddy Burru <vburru@marvell.com>,
        Abhijit Ayarekar <aayarekar@marvell.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Tue, 24 May 2022 12:27:51 +0200
In-Reply-To: <1653374469-30555-1-git-send-email-baihaowen@meizu.com>
References: <1653374469-30555-1-git-send-email-baihaowen@meizu.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hello,

On Tue, 2022-05-24 at 14:41 +0800, Haowen Bai wrote:
> ./drivers/net/ethernet/marvell/octeon_ep/octep_rx.c:161:18-40: WARNING:
> casting value returned by memory allocation function to (struct
> octep_rx_buffer *) is useless.
> 
> and we do more optimization:
> 1. remove casting value
> 2. use obvious size
> 3. use kvcalloc instead of vzalloc
> 
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>

This looks like net-next material and net-next is closed for the next 2
weeks:

http://vger.kernel.org/~davem/net-next.html

Please repost when it re-opens.

Thanks,

Paolo