Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp3025828ioo; Tue, 24 May 2022 11:12:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx/nT/+tmk5z/xrTnmFCL3wjVHdfezPIiteB+3XcqpCjT/yMEgiA/p55DTQmrDWtCCv6Jtf X-Received: by 2002:a65:6c12:0:b0:3db:a518:ff1b with SMTP id y18-20020a656c12000000b003dba518ff1bmr24608966pgu.315.1653415944891; Tue, 24 May 2022 11:12:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653415944; cv=none; d=google.com; s=arc-20160816; b=twWPdm42MvZ0ngetXf1xH1xlT5g4NHGLIYXDS9iQ4W6B7pYqzFHkmuJkRZbMhSwlke wIgxX9wTX5olGKvxch4/nr2Jil6y5aULRCH5X0XWu/5r8zpuMKgQhilneAnI5ixUFTR4 OFNgDoFPbnJpv0n8Sqh8W7P3U4il2BjzyXMQw9Q5ksF294LoQSblZRzoRaC4n2DNwpD7 h/D3BJGHgnkG3Y2hEAFYSQ6SsBGU732KFEfRZ64uFdvCy0+AUj2eFHtWwu/970h6TDDO ryYCY4AOCXZHc4qWFC7wKL3I2PTJxtdsE6YNqdq244nipNTmw/EVpGPJ3P5/waDdugoz uakg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=cJqPgN87UYNRsdNeSSFsjzHet7+5vgEzk9S+L5xumcg=; b=jga06P/F8DdVT4XlP7lrp8I3KBY6T6L3px7DXYqrcgQvifa5uOK89lrrW9yRivpucQ P+d6wRbLd5dz27WgvImDzDQ834x4+0FUwWy6WkTepM/GiZ9WZw7ma072pzf1rTzhql+G +10ojkq+qII3p3JwKCP/8IIkqngqEaM1FFB63MadDPnHPusyIFRzk1Zi0eLoicW9oCPH 35y7ANtEx+ZdxMRKITj3E27nS6hFFNO15ArZHjKRtlGIG4WhQfoGdPEb8AkyDdgiR7IB syTiUoD0dQhGCNhjOO/WkqAQHLew12Kbu/TLlfRwu77uBsB5YBVKxPoB+VFMb/yD0WIa QaGQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=tUzJal9K; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d5-20020a636805000000b003c6566867b9si14268756pgc.344.2022.05.24.11.12.12; Tue, 24 May 2022 11:12:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=tUzJal9K; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235348AbiEXJTe (ORCPT + 99 others); Tue, 24 May 2022 05:19:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235356AbiEXJTd (ORCPT ); Tue, 24 May 2022 05:19:33 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 306947892E for ; Tue, 24 May 2022 02:19:30 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id C0A7121979; Tue, 24 May 2022 09:19:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1653383968; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cJqPgN87UYNRsdNeSSFsjzHet7+5vgEzk9S+L5xumcg=; b=tUzJal9KdPkQ2D1bI89IAWjfabnibPussPwISv+c1Np0EMzF/hXlodVqFI/FHKtEftyrYy 3FhvIxUFBMEFTpjiJFaSpdhkrWTNJjBPvbShUi5FA2/hILoJWOCecoC0wnr9EGPI17xZoc GFfyJDWADknjZjU23vvCcEKozuGnUjw= Received: from suse.cz (unknown [10.100.201.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id A256D2C141; Tue, 24 May 2022 09:19:28 +0000 (UTC) Date: Tue, 24 May 2022 11:19:28 +0200 From: Petr Mladek To: Chris Down Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [RFC PATCH] printk: console: Allow each console to have its own loglevel Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 2022-05-18 20:46:00, Chris Down wrote: > Greg Kroah-Hartman writes: > > > +static int printk_sysctl_deprecated(struct ctl_table *table, int write, > > > + void __user *buffer, size_t *lenp, > > > + loff_t *ppos) > > > +{ > > > + int res = proc_dointvec(table, write, buffer, lenp, ppos); > > > + > > > + if (write) > > > + pr_warn_ratelimited( > > > + "printk: The kernel.printk sysctl is deprecated and will be removed soon. Use kernel.force_console_loglevel, kernel.default_message_loglevel, kernel.minimum_console_loglevel, or kernel.default_console_loglevel instead.\n" > > > > Please define "soon". > > Petr, what do you think about the timebounds here? :-) Good question. Honestly, I do not have experience with deprecating such interfaces. Any advice would be helpful. We might investigate the kernel log whether and how some sysctl interface was deprecated. I would personally keep the interface between 10-20 kernel releases. Best Regards, Petr PS: I still have to look deeper at the patchset. It might take some more days. It seems that nature is not the only one who woke up after the winter.