Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3206237b-4ee2-8707-6de9-87cfb226c87f@linux-m68k.org>
Date:   Wed, 25 May 2022 00:01:59 +1000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH 1/3] m68knommu: fix undefined reference to
 `mach_get_rtc_pll'
Content-Language: en-US
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     Linux/m68k <linux-m68k@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Arnd Bergmann <arnd@arndb.de>,
        kernel test robot <lkp@intel.com>
References: <20220518065639.2432213-1-gerg@linux-m68k.org>
 <20220518065639.2432213-2-gerg@linux-m68k.org>
 <CAMuHMdXTn6ysmjg5cr2RvYG=8f3azC1B4v=via0ePua_hv6TgA@mail.gmail.com>
 <CAMuHMdV+k4kGv+vKSGNnwhKCk3eYv5uQd=UgNJQ1HVYxuOUv5g@mail.gmail.com>
From:   Greg Ungerer <gerg@linux-m68k.org>
In-Reply-To: <CAMuHMdV+k4kGv+vKSGNnwhKCk3eYv5uQd=UgNJQ1HVYxuOUv5g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Geert,

On 24/5/22 17:49, Geert Uytterhoeven wrote:
> Hi Greg,
> 
> On Tue, May 24, 2022 at 9:46 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>> On Wed, May 18, 2022 at 8:56 AM Greg Ungerer <gerg@linux-m68k.org> wrote:
>>> Configuring for a nommu classic m68k target and enabling the generic rtc
>>> driver (CONFIG_RTC_DRV_GENERIC) will result in the following compile
>>> error:
>>>
>>>     m68k-linux-ld: arch/m68k/kernel/time.o: in function `rtc_ioctl':
>>>     time.c:(.text+0x82): undefined reference to `mach_get_rtc_pll'
>>>     m68k-linux-ld: time.c:(.text+0xbc): undefined reference to `mach_set_rtc_pll'
>>>     m68k-linux-ld: time.c:(.text+0xf4): undefined reference to `mach_set_rtc_pll'
>>>
>>> There is no definitions of "mach_set_rtc_pll" and "mach_get_rtc_pll" in the
>>> nommu code paths. Move these definitions and the associated "mach_hwclk",
>>> so that they are around their use case in time.c. This means they will
>>> always be defined on the builds that require them, and not on those that
>>> cannot use them - such as ColdFire (both with and without MMU enabled).
>>>
>>> Reported-by: kernel test robot <lkp@intel.com>
>>> Signed-off-by: Greg Ungerer <gerg@linux-m68k.org>
>>
>>> --- a/arch/m68k/kernel/time.c
>>> +++ b/arch/m68k/kernel/time.c
>>> @@ -82,6 +86,11 @@ void read_persistent_clock64(struct timespec64 *ts)
>>>   #endif
>>>
>>>   #if IS_ENABLED(CONFIG_RTC_DRV_GENERIC)
>>> +int (*mach_get_rtc_pll)(struct rtc_pll_info *);
>>> +int (*mach_set_rtc_pll)(struct rtc_pll_info *);
>>> +EXPORT_SYMBOL(mach_get_rtc_pll);
>>> +EXPORT_SYMBOL(mach_set_rtc_pll);
>>
>> Oops, this causes build failures for Q40 with CONFIG_RTC_DRV_GENERIC=n,
>> as arch/m68k/q40/config.c uses mach_]gs]et_rtc_pll() unconditionally.
> 
> I think the simplest solution is to move these up, next to mach_hwclk.

Yes, that looks to be the easiest solution.
New patch coming up.

Regards
Greg


>>> +
>>>   static int rtc_generic_get_time(struct device *dev, struct rtc_time *tm)
>>>   {
>>>          mach_hwclk(0, tm);
> 
> Gr{oetje,eeting}s,
> 
>                          Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                  -- Linus Torvalds