Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Zqiang <qiang1.zhang@intel.com>
To:     paulmck@kernel.org, frederic@kernel.org
Cc:     rcu@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v3 2/2] rcu-tasks: Remove is_idle_task() from warnings in check_holdout_task()
Date:   Tue, 24 May 2022 08:34:54 +0800
Message-Id: <20220524003454.1887414-3-qiang1.zhang@intel.com>
In-Reply-To: <20220524003454.1887414-1-qiang1.zhang@intel.com>
References: <20220524003454.1887414-1-qiang1.zhang@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Due to the rcu_tasks_pertask() already exclude idle tasks, the idle tasks
not appear in holdout list. so It is not necessary to judge whether the
tasks in the holdout list are idle tasks.

Signed-off-by: Zqiang <qiang1.zhang@intel.com>
---
 kernel/rcu/tasks.h | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h
index a28337f280e4..6a2598efd0cc 100644
--- a/kernel/rcu/tasks.h
+++ b/kernel/rcu/tasks.h
@@ -862,9 +862,8 @@ static void check_holdout_task(struct task_struct *t,
 		*firstreport = false;
 	}
 	cpu = task_cpu(t);
-	pr_alert("%p: %c%c nvcsw: %lu/%lu holdout: %d idle_cpu: %d/%d\n",
-		 t, ".I"[is_idle_task(t)],
-		 "N."[cpu < 0 || !tick_nohz_full_cpu(cpu)],
+	pr_alert("%p: %c nvcsw: %lu/%lu holdout: %d idle_cpu: %d/%d\n",
+		 t, "N."[cpu < 0 || !tick_nohz_full_cpu(cpu)],
 		 t->rcu_tasks_nvcsw, t->nvcsw, t->rcu_tasks_holdout,
 		 t->rcu_tasks_idle_cpu, cpu);
 	sched_show_task(t);
-- 
2.25.1