Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f270d92d-7c34-2f58-89c5-ccb7a8a37872@deltatee.com>
Date:   Tue, 24 May 2022 09:59:30 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Content-Language: en-CA
To:     Song Liu <song@kernel.org>, Donald Buczek <buczek@molgen.mpg.de>
Cc:     open list <linux-kernel@vger.kernel.org>,
        linux-raid <linux-raid@vger.kernel.org>,
        Christoph Hellwig <hch@infradead.org>,
        Guoqing Jiang <guoqing.jiang@linux.dev>,
        Xiao Ni <xni@redhat.com>, Stephen Bates <sbates@raithlin.com>,
        Martin Oliveira <Martin.Oliveira@eideticom.com>,
        David Sloan <David.Sloan@eideticom.com>
References: <20220519191311.17119-1-logang@deltatee.com>
 <20220519191311.17119-13-logang@deltatee.com>
 <62b09487-9223-db3d-2165-789a51230060@molgen.mpg.de>
 <CAPhsuW5FKh7VKgU+=eU4_ad4btFMwU7ymMNMZ5TZVQbv82MaHg@mail.gmail.com>
From:   Logan Gunthorpe <logang@deltatee.com>
In-Reply-To: <CAPhsuW5FKh7VKgU+=eU4_ad4btFMwU7ymMNMZ5TZVQbv82MaHg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [PATCH v1 12/15] md/raid5-cache: Add RCU protection to conf->log
 accesses
Precedence: bulk


On 2022-05-23 00:47, Song Liu wrote:
>> A problem here is that `struct r5l_log` of `conf->log` is private to raid5-cache.c and gcc below version 10 (wrongly) regards the `typeof(*p) *local` declaration of __rcu_access_pointer as a dereference:
>>
>>    CC      drivers/md/raid5.o
>>
>> In file included from ./include/linux/rculist.h:11:0,
>>
>>                   from ./include/linux/dcache.h:8,
>>
>>                   from ./include/linux/fs.h:8,
>>
>>                   from ./include/linux/highmem.h:5,
>>
>>                   from ./include/linux/bvec.h:10,
>>
>>                   from ./include/linux/blk_types.h:10,
>>
>>                   from ./include/linux/blkdev.h:9,
>>
>>                   from drivers/md/raid5.c:38:
>>
>> drivers/md/raid5-log.h: In function ‘log_stripe’:
>>
>> ./include/linux/rcupdate.h:384:9: error: dereferencing pointer to incomplete type ‘struct r5l_log’
>>
>>    typeof(*p) *local = (typeof(*p) *__force)READ_ONCE(p); \
>>
>>           ^
>>
>> ./include/linux/rcupdate.h:495:31: note: in expansion of macro ‘__rcu_access_pointer’
>>
>>   #define rcu_access_pointer(p) __rcu_access_pointer((p), __UNIQUE_ID(rcu), __rcu)
>>
>>                                 ^~~~~~~~~~~~~~~~~~~~
>>
>> drivers/md/raid5-log.h:61:6: note: in expansion of macro ‘rcu_access_pointer’
>>
>>    if (rcu_access_pointer(conf->log)) {
>>
>>        ^~~~~~~~~~~~~~~~~~
>>
>> make[2]: *** [scripts/Makefile.build:288: drivers/md/raid5.o] Error 1
>>
>> make[1]: *** [scripts/Makefile.build:550: drivers/md] Error 2
>>
>> make: *** [Makefile:1834: drivers] Error 2
> 
> This is annoying.. And there are a few other cases in raid5-log.h and
> raid5.c.
> 
> Maybe we should move the definition of r5l_log to raid5-log.h?

That's the only solution I can think of, and what I'll likely do for v2.
If anyone has a better solution I'm open to it.

Logan