Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b567d6bd-b563-f696-60f2-0fc36261d094@gmail.com>
Date:   Tue, 24 May 2022 11:30:54 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH] MIPS: Rewrite `csum_tcpudp_nofold' in plain C
Content-Language: en-US
To:     "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc:     Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Paul Cercueil <paul@crapouillou.net>,
        Nathan Chancellor <nathan@kernel.org>,
        Tiezhu Yang <yangtiezhu@loongson.cn>,
        linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
References: <alpine.DEB.2.21.2205222035380.52080@angie.orcam.me.uk>
 <7682977b-5929-890a-3a18-662fbfcede5c@gmail.com>
 <alpine.DEB.2.21.2205241811180.52080@angie.orcam.me.uk>
From:   Florian Fainelli <f.fainelli@gmail.com>
In-Reply-To: <alpine.DEB.2.21.2205241811180.52080@angie.orcam.me.uk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/24/22 10:18, Maciej W. Rozycki wrote:
> On Tue, 24 May 2022, Florian Fainelli wrote:
> 
>>>    I have visually inspected code produced and verified this change to boot
>>> with TCP networking performing just fine, both with a 32-bit and a 64-bit
>>> configuration.  Sadly with the little endianness only, because in the
>>> course of this verification I have discovered the core card of my Malta
>>> board bit the dust a few days ago, apparently in a permanent manner, and I
>>> have no other big-endian MIPS system available here to try.
>>
>> How about QEMU is not that a viable option for testing big/little endian
>> configurations?
> 
>   Yeah, for this particular change, sure.  I don't have QEMU set up however
> at the moment and would have to take some time to sort it, and it won't do
> for peripherals it doesn't implement.  The failure is a fresh problem and
> I yet need to figure out what to do about it.  A bad coincidence I guess
> as I have MIPS hardware 10 years older that still goes strong.

If that makes it any easier, OpenWrt has 4 configurations of Malta for 
QEMU which allows you to have at least networking (relevant here) for 
32/64 and le/be:

https://git.openwrt.org/?p=openwrt/openwrt.git;a=tree;f=target/linux/malta;h=90b2913dec291a1926eefc332b90b5842746c6e6;hb=HEAD

Along with a readme file on how to start those platforms:

https://git.openwrt.org/?p=openwrt/openwrt.git;a=blob;f=target/linux/malta/README;h=bbe806de3d6671d69ecc3db0fcfccf9f9176de13;hb=HEAD

It's really easy.
-- 
Florian