Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6c5f414b-870d-4cef-a6b9-7d9c19381064@gmail.com>
Date:   Tue, 24 May 2022 09:41:38 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v2] gpio: vr41xx: Use spurious_interrupt() and export it
 to modules
Content-Language: en-US
To:     Genjian Zhang <zhanggenjian123@gmail.com>,
        tsbogend@alpha.franken.de, maz@kernel.org, keescook@chromium.org,
        mark.rutland@arm.com, nathan@kernel.org, siyanteng01@gmail.com,
        yyuasa@linux.com, ralf@linux-mips.org
Cc:     linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
        huhai@kylinos.cn, k2ci <kernel-bot@kylinos.cn>
References: <20220524032847.3244853-1-zhanggenjian@kylinos.cn>
From:   Florian Fainelli <f.fainelli@gmail.com>
In-Reply-To: <20220524032847.3244853-1-zhanggenjian@kylinos.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/23/22 20:28, Genjian Zhang wrote:
> From: huhai <huhai@kylinos.cn>
> 
> modpost complains once these drivers become modules.
>    ERROR: modpost: "irq_err_count" [drivers/gpio/gpio-vr41xx.ko] undefined!
> 
> Fix it by use spurious_interrupt() and export spurious_interrupt() when
> that symbol is =m.
> 
> Fixes: 27fdd325dace ("MIPS: Update VR41xx GPIO driver to use gpiolib")
> Suggested-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Reported-by: k2ci <kernel-bot@kylinos.cn>
> Signed-off-by: huhai <huhai@kylinos.cn>
> ---
>   arch/mips/kernel/irq.c     | 3 +++
>   drivers/gpio/gpio-vr41xx.c | 2 +-
>   2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/mips/kernel/irq.c b/arch/mips/kernel/irq.c
> index 5e11582fe308..69f9a46bf9e5 100644
> --- a/arch/mips/kernel/irq.c
> +++ b/arch/mips/kernel/irq.c
> @@ -49,6 +49,9 @@ asmlinkage void spurious_interrupt(void)
>   {
>   	atomic_inc(&irq_err_count);
>   }
> +#ifdef CONFIG_GPIO_VR41XX_MODULE
> +EXPORT_SYMBOL_GPL(spurious_interrupt);
> +#endif

You should not be exporting for just a specific configuration, export it 
unconditionally. The generic IRQ layer however prefers to use 
handle_bad_irq() which is already exported, can you consider using that?
-- 
Florian