Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp3407245ioo; Tue, 24 May 2022 23:06:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxHzbkBOlehIlTr5bi4AG9TMm6LbpNq6oZsmsD4CIWTiG9EbCdqwPY3ndsWIyrALRaAvUHL X-Received: by 2002:a17:906:730b:b0:6fe:b3a0:1af2 with SMTP id di11-20020a170906730b00b006feb3a01af2mr19965873ejc.509.1653458794819; Tue, 24 May 2022 23:06:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653458794; cv=none; d=google.com; s=arc-20160816; b=a9CAxG8OehhyWc2CWCe5uNOc9/ZYA+TPjWCIMLEn9TzEAUK+aoZh/RvYZbuZMgTpsn a0S55B+GafUqMYKKZR78l7McpjUNpdo+Hv6Rpcv89NWOkZw2PiURXBMtyyTIFv6O/kM9 I55+nF7eJHM8GltikRquyqTjqfMts1GOpuhiQLXC7XaX+zz3iDV9sEDAO2Ci3EocNhh+ mu/94A6xLatpvwRyGW19Cf7hqi0Ni4UBPkhkc/MwkiZunD8Jf8hlOuy+TizprWMBHld+ oPlnfWmweXmA48qakmISm2tKFDlqWy+zhZ+fpt2cUaWxwR9Svoh3Mn5eyKaRdlGxaVuD vbKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=4apJ2YIhGkoEwTiNR6MNe7V3jPUQO6PtbPX8m3NH/3E=; b=OvV0N+PkfvRQHsBZ/WuXwyhpBTLxEqoKsis6k1GTq0m6P1tcM8S4ywzJ+WXnjHeXYV 6f/6svz1RC/nFoBQH+esfIiHm95cGmeLV6ggby02CQjZZ6/V0L0fz9d8pDnoa2gkWaXl DeSggX1pwP21ugMhKdFl9pmU1B0a/0w1dW+XH8Jl/RixYaAb62NKapi8aNOfqSjhl6Ap 3xqKCGaRiDdzoBliND2kf8ZH3e98Msh8MdKES+Y7AghflgWxjrsnr04SfKoc/uP1ZkDd AuafJxF4C5vHKjmKujrMC3rLQeq0otwkdVkgfavnZKDF8LoQNoNzR8IDvLDYF7dwZQky rcFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=TKodrGyv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ay5-20020a170907900500b006ff149fece8si502498ejc.233.2022.05.24.23.06.07; Tue, 24 May 2022 23:06:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=TKodrGyv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229543AbiEXNOl (ORCPT + 99 others); Tue, 24 May 2022 09:14:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237659AbiEXNO1 (ORCPT ); Tue, 24 May 2022 09:14:27 -0400 Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F2799969C; Tue, 24 May 2022 06:14:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1653398058; x=1684934058; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=4apJ2YIhGkoEwTiNR6MNe7V3jPUQO6PtbPX8m3NH/3E=; b=TKodrGyvGhRuZTM21Tq/QcO9Vfkmp+VOJe/3+NA4XKa0vKuVbfRxkrXJ hx70TLgbFKnpY5kRGValFopUq2AmiW2RDSMIrrjE6ju4HktZV/kP54uc7 GlKtOTR9Asc1RsRVdNA7ifRWI72HAfGBKfLr1jKJ+oqbEk2cxJwV8F6sV A=; Received: from unknown (HELO ironmsg02-sd.qualcomm.com) ([10.53.140.142]) by alexa-out-sd-01.qualcomm.com with ESMTP; 24 May 2022 06:14:17 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg02-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2022 06:14:17 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 24 May 2022 06:14:17 -0700 Received: from blr-ubuntu-87.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 24 May 2022 06:14:14 -0700 From: Sibi Sankar To: CC: , , , , , , Siddharth Gupta , Sibi Sankar Subject: [PATCH 6/7] remoteproc: qcom: Check elf class before minidump Date: Tue, 24 May 2022 18:43:36 +0530 Message-ID: <1653398017-28426-7-git-send-email-quic_sibis@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1653398017-28426-1-git-send-email-quic_sibis@quicinc.com> References: <1653398017-28426-1-git-send-email-quic_sibis@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Siddharth Gupta When the minidump is done with the elf64 class we need to create the dumps using the section headers, otherwise we need to default to dump creation using the program headers. Fixes: 8ed8485c4f05 ("remoteproc: qcom: Add capability to collect minidumps") Signed-off-by: Siddharth Gupta Signed-off-by: Sibi Sankar --- drivers/remoteproc/qcom_common.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/remoteproc/qcom_common.c b/drivers/remoteproc/qcom_common.c index 4b91e3c9eafa..959fb24d57ec 100644 --- a/drivers/remoteproc/qcom_common.c +++ b/drivers/remoteproc/qcom_common.c @@ -174,7 +174,11 @@ void qcom_minidump(struct rproc *rproc, unsigned int minidump_id) dev_err(&rproc->dev, "Failed with error: %d while adding minidump entries\n", ret); goto clean_minidump; } - rproc_coredump_using_sections(rproc); + + if (rproc->elf_class == ELFCLASS64) + rproc_coredump_using_sections(rproc); + else + rproc_coredump(rproc); clean_minidump: qcom_minidump_cleanup(rproc); } -- 2.7.4