Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.62.198 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; pr=C
Envelope-to: dev_public@wujek.eu,
 linux-arm-kernel@lists.infradead.org,
 linux-i2c@vger.kernel.org,
 linux-kernel@vger.kernel.org
Message-ID: <006cdaf6-2fe3-7f01-2597-50e7da1f88c8@xilinx.com>
Date:   Tue, 24 May 2022 17:05:54 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v2] i2c: busses: i2c-cadence: fix message length when
 receive block message
Content-Language: en-US
To:     Adam Wujek <dev_public@wujek.eu>,
        Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
CC:     Michal Simek <michal.simek@xilinx.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-i2c@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20220519124946.387373-1-dev_public@wujek.eu>
 <20220519231058.437365-1-dev_public@wujek.eu>
From:   Michal Simek <michal.simek@xilinx.com>
In-Reply-To: <20220519231058.437365-1-dev_public@wujek.eu>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2022 15:05:58.3048
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 726df282-8e73-4e03-7d87-08da3d96e8a4
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch01.xlnx.xilinx.com]
X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0030.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR02MB4817
X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/20/22 01:11, Adam Wujek wrote:
> Needed by hwmon/pmbus_core driver to calculate PEC correctly.
> The hwmon/pmbus_core driver relies on bus drivers to update the message
> length of receive block transfers. Only in this type of smbus transfer
> the length is not known before the transfer is started.
> 
> Signed-off-by: Adam Wujek <dev_public@wujek.eu>
> ---
> Notes:
>      Changes in v2:
>      - fix multiline comment
> 
>   drivers/i2c/busses/i2c-cadence.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/i2c/busses/i2c-cadence.c b/drivers/i2c/busses/i2c-cadence.c
> index 805c77143a0f..a679eb390ef5 100644
> --- a/drivers/i2c/busses/i2c-cadence.c
> +++ b/drivers/i2c/busses/i2c-cadence.c
> @@ -794,6 +794,13 @@ static int cdns_i2c_process_msg(struct cdns_i2c *id, struct i2c_msg *msg,
>   		return -ETIMEDOUT;
>   	}
> 
> +	/*
> +	 * Update message len, as i2c/smbus driver (function
> +	 * i2c_smbus_xfer_emulated) relies on i2c device drivers to do this.
> +	 */
> +	if ((msg->flags & I2C_M_RECV_LEN) && (msg->flags & I2C_M_RD))
> +		msg->len = msg->buf[0] + 2; /* add len byte + PEC byte */
> +
>   	cdns_i2c_writereg(CDNS_I2C_IXR_ALL_INTR_MASK,
>   			  CDNS_I2C_IDR_OFFSET);
> 
> --
> 2.17.1
> 
> 

Shubhrajyoti: Can you please test it?

Thanks,
Michal