Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp3422684ioo; Tue, 24 May 2022 23:35:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwnzMxuFlT/5vueIJT4OA8J9pPlqURV1/0SGo/cPHk0BLe7iXTaWR0q+pGYxsQ1VonGIpBe X-Received: by 2002:a65:6a47:0:b0:3f5:d7a8:44ee with SMTP id o7-20020a656a47000000b003f5d7a844eemr27442270pgu.330.1653460506252; Tue, 24 May 2022 23:35:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653460506; cv=none; d=google.com; s=arc-20160816; b=OnwtTd6aJw5BwDEJrX3NE2GFH3tp8nf8S4m30GAMGHA/vc/24QYmLz+jh/xA6uRHJp tFntERmW6F+dsTp4DKRS6cz3Y1FVwHtRitg+oqcqLVwlmLHHoIFlsHaApD7fSEMxn1xC KXsnWrHSEoRYrx4PQAM7P/RoL2m/KyNMutef9TBEUN5PnenVFq4aqDHhMMTrNm1L/FFE Ya4AwmGUYkMkD8V1Ml5ySAsQD+fcJ5f7rUF7vcTISPeaS3zFuVe0TJSzO5xOM9/JadbJ DCH6XRufr0s4iLhJRvc2JFbDrW8Z+WcsL7MTw36UklCU7YpfQB9kjNumx0QSTJy+wVBO 8Arg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=JtpqNLkr2AzoYexv1DC/Ncnax3AR0f+Qp0xCSIOrSWY=; b=rOtGz1Hvl2W+Qbf1CtasY1sZKBrO4gsMqqSDPfSJaDof4raFZa2gXVoixtwHmEOHp3 pHjwCbGHWcdCox6/qdBjg6+aeTCQ5ar+O5EAe9WCPnBvhkSDc5E6POWU7z4pKopo1mVN 27AbgEA7fncBI5j7/V8miQSjpbjKpruuAox1x3BPf1LxQiB0FTuknssEWNYwNxeETT8P ECUycyW0Xbb/YDi5UTcVYNa4HBuf7GLpK+yD4wp/QMXUeopAU319n/SrwMMcJK8wBjj4 TgOtF9Nu8PGFBoXtEyUMyZTgXE6iYoYF4rGrtBaReR5f2da3qRpCCFfvJW3HXXBg2iyK pFLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=uNLoXVZR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 21-20020a630215000000b003fa2b26b898si13693455pgc.202.2022.05.24.23.34.51; Tue, 24 May 2022 23:35:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=uNLoXVZR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235184AbiEXNOh (ORCPT + 99 others); Tue, 24 May 2022 09:14:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237640AbiEXNOZ (ORCPT ); Tue, 24 May 2022 09:14:25 -0400 Received: from alexa-out-sd-02.qualcomm.com (alexa-out-sd-02.qualcomm.com [199.106.114.39]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93A0E994D0; Tue, 24 May 2022 06:14:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1653398054; x=1684934054; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=JtpqNLkr2AzoYexv1DC/Ncnax3AR0f+Qp0xCSIOrSWY=; b=uNLoXVZRNDwVAH40jnHy4heyCTU0mJXdqUM0vONmiNE2B504QIHI2VKa CEwnSAyxWWruavDKSMNPh/OptFbaLCANJ91O98zy1BpSO794G48eUQMAL JoiBxjKoWBL81hB71s67Kba+zEXivdsFo8acrXjumyouNzV9U9Qk600is I=; Received: from unknown (HELO ironmsg03-sd.qualcomm.com) ([10.53.140.143]) by alexa-out-sd-02.qualcomm.com with ESMTP; 24 May 2022 06:14:14 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg03-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2022 06:14:14 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 24 May 2022 06:14:14 -0700 Received: from blr-ubuntu-87.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 24 May 2022 06:14:10 -0700 From: Sibi Sankar To: CC: , , , , , , Siddharth Gupta , Sibi Sankar Subject: [PATCH 5/7] remoteproc: qcom: pas: Check if coredump is enabled Date: Tue, 24 May 2022 18:43:35 +0530 Message-ID: <1653398017-28426-6-git-send-email-quic_sibis@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1653398017-28426-1-git-send-email-quic_sibis@quicinc.com> References: <1653398017-28426-1-git-send-email-quic_sibis@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Siddharth Gupta Client drivers need to check if coredump is enabled for the rproc before continuing with coredump generation. This change adds a check in the PAS driver. Fixes: 8ed8485c4f05 ("remoteproc: qcom: Add capability to collect minidumps") Signed-off-by: Siddharth Gupta Signed-off-by: Sibi Sankar --- drivers/remoteproc/qcom_q6v5_pas.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c index e25b9315c26d..815ef2c14475 100644 --- a/drivers/remoteproc/qcom_q6v5_pas.c +++ b/drivers/remoteproc/qcom_q6v5_pas.c @@ -93,6 +93,9 @@ static void adsp_minidump(struct rproc *rproc) { struct qcom_adsp *adsp = rproc->priv; + if (rproc->dump_conf == RPROC_COREDUMP_DISABLED) + return; + qcom_minidump(rproc, adsp->minidump_id); } -- 2.7.4