Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a88900f6-da2f-d641-fb6d-7952b60cf200@intel.com>
Date:   Tue, 24 May 2022 11:38:10 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.9.0
Subject: Re: [PATCH] x86/resctrl: Fix to restore to original value when
 re-enabling hardware prefetch register
Content-Language: en-US
To:     Kohei Tarumizu <tarumizu.kohei@fujitsu.com>,
        <fenghua.yu@intel.com>, <tglx@linutronix.de>, <mingo@redhat.com>,
        <bp@alien8.de>, <dave.hansen@linux.intel.com>, <x86@kernel.org>,
        <hpa@zytor.com>, <linux-kernel@vger.kernel.org>
References: <20220518045517.2066518-1-tarumizu.kohei@fujitsu.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20220518045517.2066518-1-tarumizu.kohei@fujitsu.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WXAxU3NRVHFEUldiTlR3VHFqa1I2a2ZWUjdVeU90NFl3bUluMjQwZ3RyYzdQ?=
 =?utf-8?B?QVV1YXRvZ0xqR013ZXl0QVVYVHpSSVdhNEJremVEOEdRdWNYN3l1dnpwUkov?=
 =?utf-8?B?WVVqR3lSWVl0OXk0Qk42N1A4ZDZFZEhwZ2dIdG1DVGk5aEY5MjcyUnU2RXF6?=
 =?utf-8?B?b1hhN1ZQcDJZekdjcjVEZW4zSDRZaURxTmMvb3ExaldWdkRneFJDVkwzcFZ0?=
 =?utf-8?B?YnZkc2ZTQ3ovYWEyNTc4cFJjUWJPTGk4bkhtcGZCeFFIdEN3ZkR2dWtIbzB0?=
 =?utf-8?B?c004bngyQkQzNWdTa1dacTNPL3FWdkRyWUxWWmEzUlgyd0FoYUg5eUdkNDBW?=
 =?utf-8?B?YkJocnd4VlhCbkJOWXkwd1ViVHE3SkZVbjBBYUZkK3o5eGJyN0tTblBvQ1Bn?=
 =?utf-8?B?SDZldlYwQUxtMUNacEErOHFyUDV3cEZaZkozTzgrNmdVeDgxazM1L2xJc0tr?=
 =?utf-8?B?c1MzY2Ivc2k5dURvK2Nnd0w4dzVWS2Zyc0t4azE0T1FuOVREQUo5NGwzMWJ0?=
 =?utf-8?B?TzduNzBYV0psbXQ5VzhHSjdYNC8wcHlTczdVMlhFeGFNL01pK2g1Smg1aC81?=
 =?utf-8?B?M05GRHhhRWRRV09WaW9GSUxNVTBCU2p3amhqY0V2Q2ZzUlhuR1RQU0l4WWt3?=
 =?utf-8?B?bndrTnFvMHU5S1NGVENna1dvRHhJQlNRVFVSVndFTWRaUjVSbFJvVDE3R0hY?=
 =?utf-8?B?cEczSzhmZ3krWThuQkxZU1AvM0ZHN3FGeW9MaGJ1c3RIVGdNY1dlVnFKTUlB?=
 =?utf-8?B?SFFJMlJwaDUyZ2F6STJUR2NhaFN1NFpaeUhqbFovOG9VSGlQWi9pelZ0UnMz?=
 =?utf-8?B?dkdwUmdQZjhEQnlQKys0eXVsYmRqT3U4VTdlNzl1ZU9SK0dsN0I1R0tUaDYr?=
 =?utf-8?B?Ry9CdURlZlEra05UYi9wU3J6Mmp2dS90U1RuY2VjWkthTFI0N1ZHUmxpcVpC?=
 =?utf-8?B?NFZDWWtzK1VTSERnMjhhazFEZ2JSZkg3YXgrdWsyY0VOcUN2dFhDSEpKY2VI?=
 =?utf-8?B?TTIxZXBDanBLdnRBTC9LeXN3RWdDMFlhMlFHWUVVSzhLVGdhY3BzTVNZbjlH?=
 =?utf-8?B?djZUamZvUjhZeTNRRXpIMnp3emJwd3ZSNzdzOTlpaTdEV0ZOZk5UU1NzQ0Zy?=
 =?utf-8?B?NjVsd1VzRFhaT0RMZXRvR0FwLzBvNWJNK2svM3NmbmVTNlFEdng1TUV0T0FZ?=
 =?utf-8?B?K3FKZ05rRHI1QXUvTlF3TlFnUFkyeitTQWM5azlYZkhOZkV4YnBDakpUMlhW?=
 =?utf-8?B?enZXYmRzckhEbHVBTXFudy9vZktMOWdFT2ZzdlMzZitQald5R2tIdlRZNjRK?=
 =?utf-8?B?ZkVzZnZiKzlEZ09DMTd4ZTNsQ2hPNHVQZXhoYlh4b1V3WnZKelpuTlBmcDRZ?=
 =?utf-8?B?bXU0bGxnVzQrM3k0OFJxU2pJQmVGekYxZlB0SEtwdmovVUdUM25ZK3NzbmYw?=
 =?utf-8?B?czFKaklQSHRtRFVRQkRtWlE4S0ZCdVpvc1RraStUNDZhQktSekp4dy9iYTdF?=
 =?utf-8?B?WWJxYTZ5ZFhSNm5VS3FWTWhkL2NJYndZVDMrUjUvdXRXOUZwSVBvMnV0Yk8z?=
 =?utf-8?B?NG40VTh1RnZFQTJxa1dQU25rRDVWTWRDY2IzYjlid0xoRTJCdWp2aU40WkNW?=
 =?utf-8?B?enRkNmNZa0VCVkJhd3UvZHVnU3ZzSTB0SjdnV1MvTGtKSGd5cGg2Tjh5T0Np?=
 =?utf-8?B?eFpKUU9qLzk5Q3FadFJ3TTlzNzNMUllmS01taGRjSUp6VmtMRHk5azUvSmpm?=
 =?utf-8?B?akx1a3MzcmEyQ0ZDZWZId1pMM0hTdlJHUU9WQ2x2TmxsSkMvMWdKQ1kvNWVS?=
 =?utf-8?B?bDJEdzFjOVI1UTJaTkcyd1JMZGthd2Yxa212bEVlSDA4YUNqM1JWcElBZXhh?=
 =?utf-8?B?YWl1Wmd1TmJSeWJhTkVNckhEb093cWpmUDVWZGdNNS8xWUV4L2FVSFRXMnhE?=
 =?utf-8?B?RXZ4L1ZKOUFXMEluM0ZTTWRkbnlQeW9nUElUYXMyNng0OHhmamFiaTI2ZUlL?=
 =?utf-8?B?LzBySXpGeDhrRnYxbzJvcXlNT2ZJdGlZYVhxOTA3Qlh5eWNFbENwbGJtQllu?=
 =?utf-8?B?SXBiM01oUTdORFFtY3N1cVdFc2xhdkxxNzdjSEJObC9CMXpmS0FPK295cHZj?=
 =?utf-8?B?SjV6QngzblJLSGNjMm96bVhCVEVYcGpGV3orUmJYRk1wUlRqWmVXWDJUZXJz?=
 =?utf-8?B?SURIZWtpQlIrbDdNU0U2RmFtVm93MVBKUkt3RVlMVWNMeG9IUC8vWEJ3R3JE?=
 =?utf-8?B?TWUxS3BwbWs2aHVqUk9QMmNxbHUvb3F4akJyeVRNV1JhMmxDOEFaSlNyRXB5?=
 =?utf-8?B?cmRCVXQvdTBxZlQyZm1BMEVwZCtjQmtTNUxGc0xBUkVvZjNlU0N2SlZvSFlW?=
 =?utf-8?Q?ce8EDVIHZ+WWv6eY=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b2aab1f7-b9d2-485b-6a0b-08da3db49010
X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5744.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2022 18:38:15.3466
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /LMtCMU9NyrGvO6vmrUeUFzxYh6FDDx9R2Xh+YMlJpxVcj2ZcIjKP2SyFQnxV16RFx4/6Xq8WB/VAWBJdrL/7Hb0uP8F/JvpkmIktSiCIsA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5374
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/17/2022 9:55 PM, Kohei Tarumizu wrote:
> The current pseudo_lock.c code overwrites the value of the
> MSR_MISC_FEATURE_CONTROL to 0 even if the original value is not 0.
> Therefore, modify it to save and restore the original values.
> 
> Fixes: 018961ae5579 ("x86/intel_rdt: Pseudo-lock region creation/removal core")
> Fixes: 443810fe6160 ("x86/intel_rdt: Create debugfs files for pseudo-locking testing")
> Fixes: 8a2fc0e1bc0c ("x86/intel_rdt: More precise L2 hit/miss measurements")
> Signed-off-by: Kohei Tarumizu <tarumizu.kohei@fujitsu.com>
> ---

Thank you very much for catching this.

Acked-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette