Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Jason Gunthorpe <jgg@nvidia.com>
CC:     Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        Christoph Hellwig <hch@infradead.org>,
        "Raj, Ashok" <ashok.raj@intel.com>, Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Jean-Philippe Brucker <jean-philippe@linaro.com>,
        "Jiang, Dave" <dave.jiang@intel.com>,
        Vinod Koul <vkoul@kernel.org>,
        Eric Auger <eric.auger@redhat.com>,
        "Liu, Yi L" <yi.l.liu@intel.com>,
        "Pan, Jacob jun" <jacob.jun.pan@intel.com>,
        "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Jean-Philippe Brucker <jean-philippe@linaro.org>
Subject: RE: [PATCH v7 03/10] iommu/sva: Add iommu_sva_domain support
Thread-Topic: [PATCH v7 03/10] iommu/sva: Add iommu_sva_domain support
Thread-Index: AQHYa1GAWzo4qdZhTU6Id4ueE7eQ+K0tyd1QgABGpoCAALM2gA==
Date:   Wed, 25 May 2022 00:44:28 +0000
Message-ID: <BN9PR11MB52767C320271EC422B1D55228CD69@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20220519072047.2996983-1-baolu.lu@linux.intel.com>
 <20220519072047.2996983-4-baolu.lu@linux.intel.com>
 <BN9PR11MB5276982C37DFF0FEFC45BDD68CD79@BN9PR11MB5276.namprd11.prod.outlook.com>
 <20220524133839.GS1343366@nvidia.com>
In-Reply-To: <20220524133839.GS1343366@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+xeYM7VILk1QNh1tQuHSqPc8zva5jo4lBPdmg4YAD7jEnMo+xLS+3QcLpyz+?=
 =?us-ascii?Q?vci04vf3mvCSc4j80Mv8mevGlAddwvxzj+EGkLDODz0jnC972V+CT5fqvTPc?=
 =?us-ascii?Q?c6AvYqLOvS3fUy+AdNbWXlbKWNXVDFVUarSfo0Tbw2WdRZ72wkGZbzctVhc0?=
 =?us-ascii?Q?X38yCcBuqN1BCcyLRdr8E6mZZCafDJsmwjbyk2OWCxcDmG3O8nVE02PeZbVV?=
 =?us-ascii?Q?UqwYVJOoWN2NJykXfdDQ5t73RZwbYYM8eBjxjVuO4zFSYc6lhPY+LG0lxHq1?=
 =?us-ascii?Q?VJd9iNcdg9+akLT6NCQ8Ebwhr2L1yiF7vgv09OzehFPPEeUsksCnjCrIxmBv?=
 =?us-ascii?Q?9T2d0KSii4WIivsDnxSunA4MsYulWEbEBy7J4tDl3zCdtdEAsBbL0b/Y3yS9?=
 =?us-ascii?Q?TFWTlQwU5nKwuOzaNaHherdhBDnoA8JJa1roncZQGQ08rea9X8aPNHZNoArX?=
 =?us-ascii?Q?twhnuKq+2gC8K3ioC3nCYYgqtXZDnpD2mDpw/6mu1s5KVaJIhs+7Lco+gfBm?=
 =?us-ascii?Q?RPH54dPvaGhLuwfEJHyQmxnma6fwnDOihjjmuLH39QsPOebwaHfCG5O2kW1Z?=
 =?us-ascii?Q?eLJfH57uRv2Sb9Zra1XMI4bIXElav079f5nnzDW4FUCxSuiEi/WtJmQQ6iPv?=
 =?us-ascii?Q?DC8vnCf+XKpM3BEZR4Fx+yxXoFubgUn2lRZToMA5730OzvNCC+x14FIr2WCC?=
 =?us-ascii?Q?Cwf903ogTzNObViXWUk8GzEEtMO929UeBRKfkrLl81rxu27PNbCZtMjaM+9u?=
 =?us-ascii?Q?GYVxPGd67+d3+g2Egif+cyOSxpaouB4N83SV8VMiizsLYpd4QI0rGjqDFLMN?=
 =?us-ascii?Q?1QJxGmjM7xxCEdRF+P53N+ViLuF0sKAS8wh4sGd1sE6xc61KldT8o3GWiyGc?=
 =?us-ascii?Q?apuxcxQSpVzZOWxxgNxHEF8i6SHrSUG6G4Jelx22yVfihYiov5enWu8JsjSH?=
 =?us-ascii?Q?yLgRmOHtPtBhSoTgg7Xm8E18GNwbtEUKFZ/gJJv3o/JbDGPQ2URlHD8FEQSh?=
 =?us-ascii?Q?BHn0qORYb+JvgAkYDtv0qAQb1yAT91uvu8wUXLFKjMSF84t0cFM6kgB9Sw1u?=
 =?us-ascii?Q?DGCaqZ8FlyiGmM91ffMv45iPdkiSo7NZq+5q9XN1bnKPvDFl5DyI+qFIRzfN?=
 =?us-ascii?Q?MPVuBsr9DlDP2g3+RhSyEBQdewafs8EkFdXBO+xbqQzkxE3uMWghRrc/xl5i?=
 =?us-ascii?Q?bjdBcBXoXHRY0lwts/XaFsn+8FHgXb9TrZAG4dkHZcpNA67j2Pn317sZkudW?=
 =?us-ascii?Q?9IQh2coWFQjhzUtRWlbZaoWfNx+6AkkpfUfANyuTzjCozmH+QBluQrWSJcBv?=
 =?us-ascii?Q?hMsZ14TMyXODv3HtjQuFR6letyw/xxeOQSwdPe61yHjZmg0d/YYn7HbZG2Ze?=
 =?us-ascii?Q?Yp1idvKGWiOOo8/oWtQpEmnKj3Y8NF0OU8aWM/unK8bhkaXPeuQ8gc4UZz4A?=
 =?us-ascii?Q?GJko/98yyBQsXRRwmz0kVWMgpRoMu1gQ/dCPuiM31x80Kka2LOonweGF6vJc?=
 =?us-ascii?Q?x1vFxZh62d0Cw/QlU3SI5TupgXBPHL4/6tCw3M5QrCiu6+oOCtcSQgxxmKZ/?=
 =?us-ascii?Q?1HEy3874C74yrFxRF4m6wRDp9cSx3qtUrv7vxGo+CmowiZan28rpVQxb59AH?=
 =?us-ascii?Q?e7NafeyHTNonqUSflADLuD4QZMiXSE+FoWf4pPEiAc17FxP42z1q7rBsJR2S?=
 =?us-ascii?Q?dlxpez0V3Aeh19UIn1Ww9YK0ulR90jIO6B5HPhexKziuTdd+91Zj3GA0wNmI?=
 =?us-ascii?Q?kAzQwcPl9A=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2bf768c8-9b04-47f8-f97e-08da3de7b9b2
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 May 2022 00:44:28.8444
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: XKyBsm0jpD42WejYkHHcDAo1BKZVTA/4JhBUSKg9eWBpktAA6KIbiBnXVAF+CJY+pZ7YPrmWO8fSBc6jGKM5Fw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4256
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Jason Gunthorpe <jgg@nvidia.com>
> Sent: Tuesday, May 24, 2022 9:39 PM
>=20
> On Tue, May 24, 2022 at 09:39:52AM +0000, Tian, Kevin wrote:
> > > From: Lu Baolu <baolu.lu@linux.intel.com>
> > > Sent: Thursday, May 19, 2022 3:21 PM
> > >
> > > The iommu_sva_domain represents a hardware pagetable that the
> IOMMU
> > > hardware could use for SVA translation. This adds some infrastructure
> > > to support SVA domain in the iommu common layer. It includes:
> > >
> > > - Add a new struct iommu_sva_domain and new IOMMU_DOMAIN_SVA
> > > domain
> > >   type.
> > > - Add a new domain ops pointer in iommu_ops. The IOMMU drivers that
> > >   support SVA should provide the callbacks.
> > > - Add helpers to allocate and free an SVA domain.
> > > - Add helpers to set an SVA domain to a device and the reverse
> > >   operation.
> > >
> > > Some buses, like PCI, route packets without considering the PASID val=
ue.
> > > Thus a DMA target address with PASID might be treated as P2P if the
> > > address falls into the MMIO BAR of other devices in the group. To mak=
e
> > > things simple, the attach/detach interfaces only apply to devices
> > > belonging to the singleton groups, and the singleton is immutable in
> > > fabric i.e. not affected by hotplug.
> > >
> > > The iommu_set/block_device_pasid() can be used for other purposes,
> > > such as kernel DMA with pasid, mediation device, etc. Hence, it is pu=
t
> > > in the iommu.c.
> >
> > usually we have 'set/clear' pair or 'allow/block'. Having 'set' paired
> > with 'block' doesn't read very clearly.
>=20
> I thought we agreed we'd use the blocking domain for this? Why did it
> go back to an op?
>=20

Probably it's based on following discussion:

https://lore.kernel.org/all/c8492b29-bc27-ae12-d5c4-9fbbc797e310@linux.inte=
l.com/

--
> FWIW from my point of view I'm happy with having a .detach_dev_pasid op
> meaning implicitly-blocked access for now.=20

If this is the path then lets not call it attach/detach
please. 'set_dev_pasid' and 'set_dev_blocking_pasid' are clearer
names.
--

Looks Baolu chooses this path and plans to use the blocking domain
later.

Thanks
Kevin