Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5c691c83-480b-8731-7e6a-7f28536c9a59@kernel.org>
Date:   Wed, 25 May 2022 08:44:38 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: lirc build broken [was: [GIT PULL for v5.18-rc1] media updates]
Content-Language: en-US
From:   Jiri Slaby <jirislaby@kernel.org>
To:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linux Media Mailing List <linux-media@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Sean Young <sean@mess.org>
References: <20220322101406.459e2950@coco.lan>
 <a0470450-ecfd-2918-e04a-7b57c1fd7694@kernel.org>
In-Reply-To: <a0470450-ecfd-2918-e04a-7b57c1fd7694@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 25. 05. 22, 8:42, Jiri Slaby wrote:
> On 22. 03. 22, 10:14, Mauro Carvalho Chehab wrote:
>> Hi Linus,
>>
>> Please pull from:
>>    git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media 
>> tags/media/v5.18-1
> ...
>> Sean Young (10):
> ...
>>        media: lirc: remove unused lirc features
> 
> Hi,
> 
> this breaks lirc build:
>> [   59s] lircd.cpp:489:49: error: 'LIRC_CAN_SET_REC_FILTER' was not 
>> declared in this scope; did you mean 'LIRC_CAN_SET_REC_CARRIER'?
>> [   59s]   489 |                     || (curr_driver->features & 
>> LIRC_CAN_SET_REC_FILTER)) {
>> [   59s]       |                                                 
>> ^~~~~~~~~~~~~~~~~~~~~~~
>> [   59s]       |                                                 
>> LIRC_CAN_SET_REC_CARRIER
>> [   59s] lircd.cpp: In function 'void loop()':
>> [   59s] lircd.cpp:2069:82: error: 'LIRC_CAN_NOTIFY_DECODE' was not 
>> declared in this scope; did you mean 'DRVCTL_NOTIFY_DECODE'?
>> [   59s]  2069 |                         if (curr_driver->drvctl_func 
>> && (curr_driver->features & LIRC_CAN_NOTIFY_DECODE))
>> [   59s]       
>> |                                                                                  
>> ^~~~~~~~~~~~~~~~~~~~~~
>> [   59s]       
>> |                                                                                  
>> DRVCTL_NOTIFY_DECODE
> 
> So the uapi header defines should be brought back, IMO.

(And lirc fixed at the same time.)

> thanks,-- 
js