Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6c692ace-9902-e11f-21c2-ef464be4d3c6@huawei.com>
Date:   Wed, 25 May 2022 09:24:15 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH] riscv/kprobe: reclaim insn_slot on kprobe unregistration
To:     Jisheng Zhang <jszhang@kernel.org>, Guo Ren <guoren@kernel.org>
CC:     <paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
        <aou@eecs.berkeley.edu>, <mhiramat@kernel.org>,
        <rostedt@goodmis.org>, <peterz@infradead.org>,
        <naveen.n.rao@linux.vnet.ibm.com>,
        <linux-riscv@lists.infradead.org>, <linux-kernel@vger.kernel.org>
References: <20220523015124.98743-1-liaochang1@huawei.com>
 <Yoz16RUZvfyxmywT@xhacker>
From:   "liaochang (A)" <liaochang1@huawei.com>
In-Reply-To: <Yoz16RUZvfyxmywT@xhacker>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 2022/5/24 23:12, Jisheng Zhang 写道:
> On Mon, May 23, 2022 at 09:51:24AM +0800, Liao Chang wrote:
>> On kprobe registration kernel allocate one insn_slot for new kprobe,
>> but it forget to reclaim the insn_slot on unregistration, leading to a
>> potential leakage.
> 
> + Guo Ren
> 
> Nice catch! I think csky needs the fix as well.
> 
>>
>> This bug reported by Chen Guokai <chenguokai17@mails.ucas.ac.cn>.
> 
> This needs a "Reported-by: ..." tag

Thanks for comment.

> 
>>
>> Signed-off-by: Liao Chang <liaochang1@huawei.com>
>> ---
>>  arch/riscv/kernel/probes/kprobes.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/riscv/kernel/probes/kprobes.c b/arch/riscv/kernel/probes/kprobes.c
>> index e6e950b7cf32..f12eb1fbb52c 100644
>> --- a/arch/riscv/kernel/probes/kprobes.c
>> +++ b/arch/riscv/kernel/probes/kprobes.c
>> @@ -110,6 +110,10 @@ void __kprobes arch_disarm_kprobe(struct kprobe *p)
>>  
>>  void __kprobes arch_remove_kprobe(struct kprobe *p)
>>  {
>> +	if (p->ainsn.api.insn) {
>> +		free_insn_slot(p->ainsn.api.insn, 0);
>> +		p->ainsn.api.insn = NULL;
>> +	}
>>  }
>>  
>>  static void __kprobes save_previous_kprobe(struct kprobe_ctlblk *kcb)
>> -- 
>> 2.17.1
>>
>>
>> _______________________________________________
>> linux-riscv mailing list
>> linux-riscv@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-riscv
> .

-- 
BR,
Liao, Chang