Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Himanshu Madhani <himanshu.madhani@oracle.com>
To:     Tom Rix <trix@redhat.com>
CC:     Nilesh Javali <njavali@marvell.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        Martin Petersen <martin.petersen@oracle.com>,
        GR-QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@marvell.com>,
        linux-scsi <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: qla2xxx: remove setting of 'req' and 'rsp'
 parameter
Thread-Topic: [PATCH] scsi: qla2xxx: remove setting of 'req' and 'rsp'
 parameter
Thread-Index: AQHYbU+pycrjMrmuMUGpDqoT9CGnB60uWGuA
Date:   Tue, 24 May 2022 18:10:18 +0000
Message-ID: <A39923A2-373C-4EF8-997B-2A12821ED4E8@oracle.com>
References: <20220521201607.4145298-1-trix@redhat.com>
In-Reply-To: <20220521201607.4145298-1-trix@redhat.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?310Ih2XWcJA9/D00H3aXsvodvc6ggbMQV+aCIUHOmSxy1C2mMYLCJHKFDSFq?=
 =?us-ascii?Q?ygBdsA1lWmOvCEizflHCjslGRQKkNOJbrZQVzG3PEJ3NhNpwAuk37KMNDf1g?=
 =?us-ascii?Q?byfvAoSEJ965OEopr2WPjA2eOqaI5VqpdozPwponTK58gkjnHRJ5iN5jTlO9?=
 =?us-ascii?Q?mU+1ndCjBaS6eL9cfHsJb8h5Q/4nEpwLNQXiUd2JSRQYi5nZ8JNqu+CK0jgK?=
 =?us-ascii?Q?w9ThP4ZMvr2+DCMHK/k1Klhnn+Q2dQreYHhUvPzGmqfEbrSKoEr45SX3iIUo?=
 =?us-ascii?Q?IwMO57bKq6Jhmzp/mgWEFbvEDED1JprdGR50cjSd2pFJhz1iY6ovNLZmtXVb?=
 =?us-ascii?Q?f+cC8pjve8azY1s+qOOHOEMknMVk5ujpKTfJVAFvguEtnusnklWPcFdOjaXi?=
 =?us-ascii?Q?inJLFnMgsgHMlPio/R83ev1v4Q/JL5PQC66CEXCkor4JcogdYpXsHn71eLAV?=
 =?us-ascii?Q?1evHoigiaF7NjkotsvZoBkSeQSxIV2tXt4sz111GZ3bxjOCfkgG0cdxPM5+3?=
 =?us-ascii?Q?rnEX3Mu1CConVOJWOda944HjGyGrb0xCuoVkRXtndMl+1SUxZkrkGlj3sHy0?=
 =?us-ascii?Q?p95Abw3dELafMNqfjUwIpT2ClSYzETkWONyskeLIDfW6ggW7dXBPvAgluooF?=
 =?us-ascii?Q?Evbvf+jsGXxivNByE0hdEEYHOnga3OW1fgl5UDtxJXAH//rKBcXWZHuB8IAS?=
 =?us-ascii?Q?kWOwVJCM6S7KRfII67ZUTWDwvxLeEAms2DjdhQHNcQHUyEUaBEb0+L7Itfor?=
 =?us-ascii?Q?G6A+0HVyM0ZMB77qEFeijmHr6T2BU2PME903X/LWuQPp02KBNDN8wD8EiEnM?=
 =?us-ascii?Q?dS50DDMu+gEG7tj7HV/tx94UP1hsAWGZN9MeMZS1zf1N7INM5vA1BF8trpKV?=
 =?us-ascii?Q?5ODbtCarF5ayj/h+1C20V3mnta+Y4MVceyY5fbcvreBYuaN6mWe+vcGPHfo4?=
 =?us-ascii?Q?/X6q5oTA2aIi8oAkjgjdd4wNcUK2pbaiXiVKe/K36WLtujgG2cVGO/jXEYAx?=
 =?us-ascii?Q?z2La+CMVa9/gPKgJaecMu5urLl3rTHDIRWU3XF2wXy5zsNlCSsL+5rtrpm86?=
 =?us-ascii?Q?EYkymKAznXrQlGELVSTK+chgVNMcmwq8O8JO6C4YcEKo5nZ0s+sBDzZhCGu5?=
 =?us-ascii?Q?QagsDpinsUReLTzWB3mauOZGQ4zg/ThzzhzRgLm/lCzCUuZxnisxBVRVDZ7C?=
 =?us-ascii?Q?UhIRQe1gf6VsHgY/ouMOo1EzSQPYrm+5S2EFBUnxKuhXD2IPpFAOV9HC5op7?=
 =?us-ascii?Q?NF0gsTdt8nUsa+Q3vpDqPdCUoAk+mzNAKn/mOx9ztpU+yNQIgLz3Qedo2Gmg?=
 =?us-ascii?Q?yuZt829fpakJo5FiQpTGZb7mukX0RUmuMjPh0xPCJTY+IC5CkXSj6mKwCzYN?=
 =?us-ascii?Q?W7BhhLc9idtWnfLby3wG5QJogQ4kyWJM+rqN0A58QaoDTy12qKBXFoxjwgsC?=
 =?us-ascii?Q?HgCiZ5sWhVEbnttO+U1UnO5Ude4Fl+jukR7FL/zVwgZzOPdQZEe5hNE8mW7h?=
 =?us-ascii?Q?QGsypLO8ui9x2VEuaKmEIv6OnsUfNDz+poSMoum0ZybxMzKbhoT6uvLZRl3k?=
 =?us-ascii?Q?ihPoHvvga1OABgWbXjwDsuuoaZcl97enLxKV8q7WokgmnjW5DRWP7n1PcDIq?=
 =?us-ascii?Q?rlHfIbIgX3boQnU9EW9XSQKQWOAsaq6fbJ0vMhMbJPWFF30A9U+vJOrEiM1h?=
 =?us-ascii?Q?qCa9f/ZyLiDq5wdjmYnqwJEwHcd2Pe9ROrmPBw/kODETsyi0pNcPoobtRXrQ?=
 =?us-ascii?Q?JkZC4ZeiGSVMRRF+F1JCPNA/do++9HoCIxEpOWIQ7IQux3shX+/O?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <337ACEE1798AC247BCC31B982D82528E@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB2943.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: babecdff-28db-4b2f-ed3a-08da3db0a8bf
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2022 18:10:18.0879
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6UmRTVVGzX8/kgGpifv1N8U5KZjRzjLEr6Js4x+UMuv1fQu84IJSxiQcIFDK+JfBEY/FHzVLoBe/ENpyFlIlnafLX9iBDb3crdlmkm+ysP8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5261
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.874
 definitions=2022-05-24_07:2022-05-23,2022-05-24 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0
 adultscore=0 bulkscore=0 suspectscore=0 phishscore=0 mlxscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2205240089
X-Proofpoint-GUID: H3RC6gQhm5vR-bI4kjK0S_WCVlkvs4il
X-Proofpoint-ORIG-GUID: H3RC6gQhm5vR-bI4kjK0S_WCVlkvs4il
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On May 21, 2022, at 1:16 PM, Tom Rix <trix@redhat.com> wrote:
>=20
> cppcheck reports
> [drivers/scsi/qla2xxx/qla_mid.c:594]: (warning) Assignment of function pa=
rameter has no effect outside the function. Did you forget dereferencing it=
?
> [drivers/scsi/qla2xxx/qla_mid.c:620]: (warning) Assignment of function pa=
rameter has no effect outside the function. Did you forget dereferencing it=
?
>=20
> The functions qla25xx_free_req_que and qla25xx_free_rsp_que are similar.
> They free a 'req' and a 'rsp' parameter respectively.  The last statement=
 of
> both functions is setting the parameter to NULL.  This has no effect and
> can be removed.
>=20
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/scsi/qla2xxx/qla_mid.c | 2 --
> 1 file changed, 2 deletions(-)
>=20
> diff --git a/drivers/scsi/qla2xxx/qla_mid.c b/drivers/scsi/qla2xxx/qla_mi=
d.c
> index e6b5c4ccce97..346d47b61c07 100644
> --- a/drivers/scsi/qla2xxx/qla_mid.c
> +++ b/drivers/scsi/qla2xxx/qla_mid.c
> @@ -591,7 +591,6 @@ qla25xx_free_req_que(struct scsi_qla_host *vha, struc=
t req_que *req)
> 	}
> 	kfree(req->outstanding_cmds);
> 	kfree(req);
> -	req =3D NULL;
> }
>=20
> static void
> @@ -617,7 +616,6 @@ qla25xx_free_rsp_que(struct scsi_qla_host *vha, struc=
t rsp_que *rsp)
> 		mutex_unlock(&ha->vport_lock);
> 	}
> 	kfree(rsp);
> -	rsp =3D NULL;
> }
>=20
> int
> --=20
> 2.27.0
>=20

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

--
Himanshu Madhani	Oracle Linux Engineering