Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp3548294ioo; Wed, 25 May 2022 03:11:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxywBuHcRLszglV8bpwOfDXWO4TguvW9eth8g1c/kN138aubNhKYiTbiw+E7ITV7Hbhoecl X-Received: by 2002:a05:6402:176b:b0:42a:a828:5d79 with SMTP id da11-20020a056402176b00b0042aa8285d79mr33884671edb.272.1653473499220; Wed, 25 May 2022 03:11:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653473499; cv=none; d=google.com; s=arc-20160816; b=uQqpbvI19UXl8DQWzXLdG63pD/zst1lxDxicp5EJISoZZNyaWpTRnQgTAXjghBBWNW 6vTcHaFRH+mpxck388ytBlL+SYaLTdSE7zdHZVc+X3wMWgg6EnkRS2LhMiJspqCf3+7V n5gU1dZ6xpxqQPPNOPYFQvmwOxGyag0Q6ZVECIVXj2JNeK5Dr8f/dxXMQ0kadYl6JtEw SZn+M7PcaznaRfyIflzvgbL1HfAI5M/ZMFpsWMxdKM2FV1Czx+upaBuJkW3ZWh5xofq9 wOZhUWf2FCJ6HDUeJaJiA2whRsOEcuEaY9SRpLlJpF72ulUwKtYEzfJaHzrXyavWz8uH 8tLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding:in-reply-to :from:references:cc:to:content-language:user-agent:mime-version:date :message-id:dkim-signature; bh=XGDP2IvqeiAPfkB1fEXqR1oCpPgMjf7+++fKTxZ22jU=; b=zWTT9WFmZ6fqQ0bQ4krNamhyswWb+0nIj/Z9u7E50YXr2hBQIAb2VNzhlHH3/ZpwCZ wLWloQq67apBX59GRiRkjqTNTELOiHPF91xd7sokj9xftqqSJkOW+d+NPb2Hr63M+X0V n5nr3OVO7Q0QHHCxQDSpKP0yJBvhzlBUTr0OFP2FAR6N+jilPdQR/GUOcxOc+k/DYM05 kCETP/usaXKXmRvfYXBVUembdZ5LcTJHhEGjVEwTRBAL80yCr4SapkDgEuGcB0lh/Hsf WpLW1CyVylQq26XAuh9GzO21WPha6pb73rpLQzbCU5whsZH6eohVubDegcQToGt9Dqcv HgJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@deltatee.com header.s=20200525 header.b=cJ1yIMVC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=deltatee.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l2-20020a170906644200b006ff145bdb7csi1009128ejn.373.2022.05.25.03.11.11; Wed, 25 May 2022 03:11:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@deltatee.com header.s=20200525 header.b=cJ1yIMVC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=deltatee.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237549AbiEXQOK (ORCPT + 99 others); Tue, 24 May 2022 12:14:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229978AbiEXQOI (ORCPT ); Tue, 24 May 2022 12:14:08 -0400 Received: from ale.deltatee.com (ale.deltatee.com [204.191.154.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDB627E1DA; Tue, 24 May 2022 09:14:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=deltatee.com; s=20200525; h=Subject:In-Reply-To:From:References:Cc:To: MIME-Version:Date:Message-ID:content-disposition; bh=XGDP2IvqeiAPfkB1fEXqR1oCpPgMjf7+++fKTxZ22jU=; b=cJ1yIMVCtQ7ipXSQVLynmD/FfD 486cR3k3hKaBGM4cHLtcE/kP06K/K0wdkObYYS4+dbSlsI0lL2ifA/bnTviOWlnT/J06O28dJHv/x n+QM10yo2srfShlTRLfzcwhBajjgS10V3gN8co2PUwLLf5S3E079W7I5nRbfMh0lYHVncGi0uSN0Z njte8dfnPAmKZh7Q6izRGtR19ngHlVhcT31/5cbE645HGcOO1lzMK1h9lhXufk88p1OAoTQmwTSwU lydgqcnkOQQ7qzaE3vgiA7FBgHbDFW4HstjH+r6wTxXh/Q9di3lcluztfn6da0yKNLFUKRXAVx/4J af1T2Mlg==; Received: from guinness.priv.deltatee.com ([172.16.1.162]) by ale.deltatee.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1ntXAa-006Rce-9A; Tue, 24 May 2022 10:14:05 -0600 Message-ID: Date: Tue, 24 May 2022 10:14:03 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Content-Language: en-CA To: Song Liu , Donald Buczek Cc: open list , linux-raid , Christoph Hellwig , Guoqing Jiang , Xiao Ni , Stephen Bates , Martin Oliveira , David Sloan References: <20220519191311.17119-1-logang@deltatee.com> <20220519191311.17119-13-logang@deltatee.com> <62b09487-9223-db3d-2165-789a51230060@molgen.mpg.de> From: Logan Gunthorpe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: song@kernel.org, buczek@molgen.mpg.de, linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, hch@infradead.org, guoqing.jiang@linux.dev, xni@redhat.com, sbates@raithlin.com, Martin.Oliveira@eideticom.com, David.Sloan@eideticom.com X-SA-Exim-Mail-From: logang@deltatee.com X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 Subject: Re: [PATCH v1 12/15] md/raid5-cache: Add RCU protection to conf->log accesses X-SA-Exim-Version: 4.2.1 (built Sat, 13 Feb 2021 17:57:42 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-05-23 12:15, Song Liu wrote: > On Sun, May 22, 2022 at 11:47 PM Song Liu wrote: >> Maybe we should move the definition of r5l_log to raid5-log.h? > > Or we can use READ_ONCE(conf->log) for most cases. READ_ONCE() will still generate sparse errors. Logan