Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <31b76df0-1b90-6494-57e7-fc9099c68e24@intel.com>
Date:   Tue, 24 May 2022 11:56:13 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.9.0
Subject: Re: [PATCH] x86/resctrl: Fix to restore to original value when
 re-enabling hardware prefetch register
Content-Language: en-US
To:     Dave Hansen <dave.hansen@intel.com>,
        Kohei Tarumizu <tarumizu.kohei@fujitsu.com>,
        <fenghua.yu@intel.com>, <tglx@linutronix.de>, <mingo@redhat.com>,
        <bp@alien8.de>, <dave.hansen@linux.intel.com>, <x86@kernel.org>,
        <hpa@zytor.com>, <linux-kernel@vger.kernel.org>
References: <20220518045517.2066518-1-tarumizu.kohei@fujitsu.com>
 <bc5e9175-e609-d5f8-da33-65e97d4fd813@intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <bc5e9175-e609-d5f8-da33-65e97d4fd813@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WGJ6QWdSbDdnY1VBQnlQdVZkZEZRL3o5STBCN0hGZmd2cFk5disvS1BnNnBC?=
 =?utf-8?B?TXJxOS9DOWFKNEsxb09zZENKM3FBZk5jNThUbGFJMlJMcURWS2dpbjBSTzJE?=
 =?utf-8?B?d3F5QVZmZXRWb3pSUjJ0cnZockwwSFVhWWJKNW51Z3B3STNkaExENitOWDlW?=
 =?utf-8?B?bTVGSFlpWGk2Z0F0dm1kS2k3aWJKb1dhK1IzVkZmeHJPRWlQWVdGSjAxNW1D?=
 =?utf-8?B?MnVwYldIR25GdWhwUHY0dzJiYUV4eFZ6ZlZaRjI3alhhVVEvK0JOa016M1dZ?=
 =?utf-8?B?WnROdS9Oa3FDdE1kMmJWSS80SG1ZM0JkdW9xR1Z2dGlHMkdTQTJqMG9YeWJy?=
 =?utf-8?B?dytRK1hxMnlxZlkweGVnVnJpZGU0VjlSNkw3TzhOUHA4RWNsWllIWkRLN2N4?=
 =?utf-8?B?VW0rNVg5Y3NRcE81SnFET0gxUmtRNDI1RUlDWUZ1ZzFrTHM4UTk0eFdCRGNu?=
 =?utf-8?B?dVFHR09TNGRWbXdvYW51bUROUXN6U1EyWExUTndpdjNsRDJTbFUwZUMyck1Q?=
 =?utf-8?B?U0ExZVF1QlRHMzZ6WWNFS1pNYnFiVW1EMXBuSnlmekZTbTRWc0IzYjNUUFNu?=
 =?utf-8?B?NjRvbmdDUFU5TnAxdE1pa2JzWDVYRmJMRTlGemUrYUhpTnlqRlREQzh2SUZj?=
 =?utf-8?B?QzlFbm54c3JrT2pjeXdORi9OQjA1MUJNc2hQTEk5blR2VUY4SkRGQkpVUHls?=
 =?utf-8?B?WGNqaDVQaXhINENGMkh1aW43L1N6TU5rcWRJZGlPd0lTSzBhUjlnYWIvVmlz?=
 =?utf-8?B?UWtoV05zYlptWUJiTTdXVERwQUdIdm5jTk5tSlVJSHdUY0ZLei8ySm1oV1Bw?=
 =?utf-8?B?UGY2NE50T2NoTUFjd01STGlGN1dxUk1wYlJ0SVgyU3ZjZ3duMjIvUFVnbVlu?=
 =?utf-8?B?SDdKMXF6T2hZZmNyK0VFRDdJcUdDWVVTVGs2ZG5FaVcvOEh6eHFMME9WT2Z0?=
 =?utf-8?B?aURhU0ZLWU5rZ2pPTHdEZXU2Zm8xaExlS1pCUnBuaGtERDRkck00TkVkSHY3?=
 =?utf-8?B?dklERmgvVGRJcEt4Mm5hS3Mwa3pKYUQ5ZndtUUZ6Y2hEbUtpeWRDMnU0S0dD?=
 =?utf-8?B?cGZWZ3Z6NnRzb3V4bkp5cEFiOVhMdVdvYkE5bU1WTUVIcmVlYnNqWms1ZTAy?=
 =?utf-8?B?dlFaL3d2eEVLZlFYS1FtVE1ZL3lIb1BrV1ZXSHZtU0Rma1FDTkN6QXlxUENs?=
 =?utf-8?B?a2J5VmtsazhEWXpZNkx1N25rODFoai9EenlJaUEyNUZEc3hCTWhRbmhWeTVJ?=
 =?utf-8?B?UVlrVkxiZlhNS2NPWWhteGp6TWhZSGNJNlE5L0Q3RFhhZTdSQjF6RVJDaFpl?=
 =?utf-8?B?eklZWlkzRFo2NUUvR2dBM1RQTkZjSXZ0clN2eGtZekRMckE1Y1VrQzRwVnpJ?=
 =?utf-8?B?NHcyejNXU0M1dmJneTF3Z3hmRVZkRkp5UjBnRGZFeVNBVWZBSWgxMGxvV3VU?=
 =?utf-8?B?RWR2Y2dFcnNpckp5eXV2aG04ZEljMmhkY3Z4a1gwSUh4MnFLNVoxNXNKNWFQ?=
 =?utf-8?B?SEVrdElIZSt6WWY4VFl5TlBvQUdoZHUxcTM3L1dISzRENnhRZkpIMHI5ZHh2?=
 =?utf-8?B?ME5WdlJEbkhUK0xUOUxBM0N1dkZxd090YnY5S1VhelBkWERIeWNsRHhZVjFm?=
 =?utf-8?B?aWVpa0RFcmNGU3NQYkhnTitYSmIxZ1daQW00TWRzRngzbk80NjRkQTYyN2ZL?=
 =?utf-8?B?UUhNZFVDSlplbjlDSm5yOHRUQUtWN3RCbW9KdzBVbkN3WEk2bEU4UWlPM2FE?=
 =?utf-8?B?Qkh1b3Q3NmVqNW9YY3A4NUMzOG5keGxvN29pd2tsUVhSQVM5a2w3emZXeXY5?=
 =?utf-8?B?cmFzM2JybGpFZzUrS3hkMHZLTVl5YlZET3g0bEpubGd1OG45RVErRFh2WkFU?=
 =?utf-8?B?MTJ6dlVxbnY5NWJycEErbmFrTnpQdjE3NHF3alBENmV0UUFFVnNRamlJL1Jo?=
 =?utf-8?B?VjlmMWYzNlJKYlYxbWFzL1ZkQkxVd1o3OGhJQ0NnTFNLVlg0MmZBbThvNnFY?=
 =?utf-8?B?azE3ZXUxSGh1MUpWWWVxMkw5OHptSzlkbjBLNTFkZzRzQTJ6L1ZEUnAzN2dU?=
 =?utf-8?B?V3R6Rkd1ZFBQY1dRMmYrejRnNW1kb1RPTUVGaE9JRnFSbk9pSFJWbGpXUGRV?=
 =?utf-8?B?Q3owVXAvMUNpc1VLd0VFdUsybU1TVmRURDd3eGZlblVWaGhyVkZBYTVSVE9O?=
 =?utf-8?B?ek1oSVhmU1YyUk1OSlZMY255QUZrbklwQUhOWUE2WjFIdFBIcVVyZXpuOTdT?=
 =?utf-8?B?aVF0UnV5d3BiSHcxSVJaQTc2bnJwbCtxN0hTQ1V5WlRWbFBnc2ZobXNhSStX?=
 =?utf-8?B?cVQ3ZjZ0QUZrRXpDSWZIMllVZ1ZadFhZWGxTNzB0SlprSWh1OXdUWU5pdFMr?=
 =?utf-8?Q?GQyzjz8nldEtKJuI=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fdbaca17-4f21-48d5-6eba-08da3db71554
X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5744.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2022 18:56:17.4698
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Rx5MeGfw5RU4TX7+Vi5UxUubqVXTHWTTI15LO3xPdgfSyJfiTd8VQQcgD/OgjzXMjhAdKTf21kzGHIdEoM1D1HffHe++YT9LcI94Rm4sSB8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2970
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Dave,

On 5/24/2022 11:41 AM, Dave Hansen wrote:
> On 5/17/22 21:55, Kohei Tarumizu wrote:
>> The current pseudo_lock.c code overwrites the value of the
>> MSR_MISC_FEATURE_CONTROL to 0 even if the original value is not 0.
>> Therefore, modify it to save and restore the original values.
>>
>> Fixes: 018961ae5579 ("x86/intel_rdt: Pseudo-lock region creation/removal core")
>> Fixes: 443810fe6160 ("x86/intel_rdt: Create debugfs files for pseudo-locking testing")
>> Fixes: 8a2fc0e1bc0c ("x86/intel_rdt: More precise L2 hit/miss measurements")
>> Signed-off-by: Kohei Tarumizu <tarumizu.kohei@fujitsu.com>
> 
> Those commits are pretty old.  Is there any reason this is not stable@
> material?

While those commits are old the backport will not be trivial since some
lines affected did change since these original patches. I did not think it would
be worth the effort considering (1) the niche usages of this code, and (2) while these
patches can be found since v4.19 this code remains the only place in the kernel
that modifies this MSR (until the rest of Kohei's series lands). Apart from this
there is no particular reason why it cannot go to stable, we can surely make the
adjustments to make it palatable for v4.19.

Reinette