Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8fed7c83-40ad-065a-847f-1faa491d44a0@arm.com>
Date:   Wed, 25 May 2022 11:06:13 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.9.0
Subject: Re: [PATCH v3 0/4] coresight: Add config flag to enable branch
 broadcast
To:     James Clark <james.clark@arm.com>, mathieu.poirier@linaro.org,
        coresight@lists.linaro.org, mike.leach@linaro.org
Cc:     leo.yan@linaro.com, Leo Yan <leo.yan@linaro.org>,
        linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220511144601.2257870-1-james.clark@arm.com>
From:   Suzuki K Poulose <suzuki.poulose@arm.com>
In-Reply-To: <20220511144601.2257870-1-james.clark@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi James,


On 11/05/2022 15:45, James Clark wrote:
> Apologies for the delay.
> 
> Changes since v2:
> 
>   * Pick up some of Mike's review tags
>   * Add a comment explaining rationale for not opening the event when BB isn't
>     supported
>   * Extend docs to say that Perf doesn't support decode when binaries are
>     modified
>   * Drop Perf side patches that were already merged
> 
> Thanks
> James
> 
> James Clark (4):
>    coresight: Add config flag to enable branch broadcast
>    Documentation: coresight: Turn numbered subsections into real
>      subsections
>    Documentation: coresight: Link config options to existing
>      documentation
>    Documentation: coresight: Expand branch broadcast documentation


The series looks good to me. Apologies, this missed the 5.19 window.
I will queue this for 5.20 at -rc1.


Suzuki

> 
>   .../coresight/coresight-etm4x-reference.rst   | 17 +++++-
>   Documentation/trace/coresight/coresight.rst   | 56 +++++++++++++++++--
>   .../hwtracing/coresight/coresight-etm-perf.c  |  2 +
>   .../coresight/coresight-etm4x-core.c          | 14 +++++
>   include/linux/coresight-pmu.h                 |  2 +
>   5 files changed, 85 insertions(+), 6 deletions(-)
>