Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1abe03bf-5de5-f73e-1043-46872a38e815@linaro.org>
Date:   Wed, 25 May 2022 14:33:18 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v2 1/7] media: camss: ispif: Correctly reset based on the
 VFE ID
Content-Language: en-GB
To:     Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
        kholk11@gmail.com, Robert Foss <robert.foss@linaro.org>,
        Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc:     agross@kernel.org, bjorn.andersson@linaro.org, mchehab@kernel.org,
        robh+dt@kernel.org, marijns95@gmail.com, konradybcio@gmail.com,
        martin.botka1@gmail.com, linux-arm-msm@vger.kernel.org,
        linux-media@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, todor.too@gmail.com
References: <20201022174706.8813-1-kholk11@gmail.com>
 <20201022174706.8813-2-kholk11@gmail.com>
 <899412f2-5ee4-cd32-393f-688fc6351437@linaro.org>
From:   Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
In-Reply-To: <899412f2-5ee4-cd32-393f-688fc6351437@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Wow, a patchset from 2020.

On 25/05/2022 12:03, Vladimir Zapolskiy wrote:
> On 10/22/20 20:47, kholk11@gmail.com wrote:
>> From: AngeloGioacchino Del Regno <kholk11@gmail.com>
>>
>> Resetting the ISPIF VFE0 context is wrong if we are using the VFE1
>> for dual-camera or simply because a secondary camera is connected
>> to it: in this case the reset will always happen on the VFE0 ctx
>> of the ISPIF, which is .. useless.
>>
>> Fix this usecase by adding the ISPIF_RST_CMD_1 address and choose
>> where to do the (or what to) reset based on the VFE line id.
>>
>> Signed-off-by: AngeloGioacchino Del Regno <kholk11@gmail.com>
>> Reviewed-by: Robert Foss <robert.foss@linaro.org>
>> ---
>>   .../media/platform/qcom/camss/camss-ispif.c   | 85 ++++++++++++-------
>>   .../media/platform/qcom/camss/camss-ispif.h   |  2 +-
>>   2 files changed, 56 insertions(+), 31 deletions(-)
>>

[skipped]

>> @@ -355,7 +379,7 @@ static int ispif_set_power(struct v4l2_subdev *sd, 
>> int on)
>>               goto exit;
>>           }
>> -        ret = ispif_reset(ispif);
>> +        ret = ispif_reset(ispif, line->vfe_id);
> 
> But in fact here is an error.
> 
> line->vfe_id is never set.
> 
> I'm unable to test any fix, since I don't have a correspondent hardware,
> but I can write a fix for someone's testing.

I have a sda660 device, but I don't have cameras attached. So one will 
have to use TPG.

-- 
With best wishes
Dmitry