Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 24 May 2022 19:26:05 -0700
From:   Roman Gushchin <roman.gushchin@linux.dev>
To:     Michal =?iso-8859-1?Q?Koutn=FD?= <mkoutny@suse.com>
Cc:     cgroups@vger.kernel.org, linux-mm@kvack.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Michal Hocko <mhocko@kernel.org>,
        Shakeel Butt <shakeelb@google.com>,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        Richard Palethorpe <rpalethorpe@suse.de>,
        Muhammad Usama Anjum <usama.anjum@collabora.com>
Subject: Re: [PATCH v3 5/5] selftests: memcg: Factor out common parts of
 memory.{low,min} tests
Message-ID: <Yo2TvWr/0Y6s9SE2@carbon>
References: <20220524162955.8635-1-mkoutny@suse.com>
 <20220524162955.8635-6-mkoutny@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220524162955.8635-6-mkoutny@suse.com>
Precedence: bulk

On Tue, May 24, 2022 at 06:29:55PM +0200, Michal Koutny wrote:
> The memory protection test setup and runtime is almost equal for
> memory.low and memory.min cases.
> It makes modification of the common parts prone to mistakes, since the
> protections are similar not only in setup but also in principle, factor
> the common part out.
> 
> Past exceptions between the tests:
> - missing memory.min is fine (kept),
> - test_memcg_low protected orphaned pagecache (adapted like
>   test_memcg_min and we keep the processes of protected memory running).
> 
> The evaluation in two tests is different (OOM of allocator vs low events
> of prot?g?s), this is kept different.
> 
> Signed-off-by: Michal Koutn? <mkoutny@suse.com>

Acked-by: Roman Gushchin <roman.gushchin@linux.dev>