Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Wed, 25 May 2022 00:37:16 +0200
From:   Michael Walle <michael@walle.cc>
To:     chf.fritz@googlemail.com
Cc:     Tudor Ambarus <tudor.ambarus@microchip.com>,
        Pratyush Yadav <p.yadav@ti.com>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        ClaudiuBeznea <claudiu.beznea@microchip.com>,
        linux-mtd@lists.infradead.org,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtd: spi-nor: atmel: Add at25ql641 support
In-Reply-To: <48b49de3712267780916b665d3b2a3323e6f10ce.camel@googlemail.com>
References: <48b49de3712267780916b665d3b2a3323e6f10ce.camel@googlemail.com>
User-Agent: Roundcube Webmail/1.4.13
Message-ID: <0123ee0e70df13b340230a38cb44548f@walle.cc>
Precedence: bulk

Hi,

Am 2022-05-24 21:20, schrieb Christoph Fritz:
> This patch adds AT25QL641 to the list of supported nor flashs.

Please mention on which spi host controller this flash was
tested.

> Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>
> ---
>  drivers/mtd/spi-nor/atmel.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mtd/spi-nor/atmel.c b/drivers/mtd/spi-nor/atmel.c
> index 656dd80a0be7..dfbc12071093 100644
> --- a/drivers/mtd/spi-nor/atmel.c
> +++ b/drivers/mtd/spi-nor/atmel.c
> @@ -186,6 +186,8 @@ static const struct flash_info atmel_nor_parts[] = 
> {
>  		.fixups = &atmel_nor_global_protection_fixups },
>  	{ "at25sl321",	INFO(0x1f4216, 0, 64 * 1024, 64)
>  		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> +	{ "at25ql641",	INFO(0x1f4317, 0, 64 * 1024, 128)
> +		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },

This flash supports SFDP, please use either SNOR_ID3() (you'll
have to pick my pending patches first [1]) or use
   { "at25ql641", INFO(0x1f4317, 0, 0, 0) PARSE_SFDP },
which will then be replaced with SNOR_ID3() once it is available.

>  	{ "at26f004",   INFO(0x1f0400, 0, 64 * 1024,  8)
>  		NO_SFDP_FLAGS(SECT_4K) },
>  	{ "at26df081a", INFO(0x1f4501, 0, 64 * 1024, 16)

-michael

[1] https://lore.kernel.org/r/966de7ad5f563f9a29db91c5309a71c6@walle.cc/