Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp3952237ioo; Wed, 25 May 2022 11:21:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx2Yoe4AkQwtxx1RhPuBz0vpfZf541MOgB6Cs44p3ndIIoGePCdc2k7tQD37rw1oXX/84jj X-Received: by 2002:a17:907:2be5:b0:6fe:cfea:2a56 with SMTP id gv37-20020a1709072be500b006fecfea2a56mr16380502ejc.496.1653502916473; Wed, 25 May 2022 11:21:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653502916; cv=none; d=google.com; s=arc-20160816; b=SMJhEbao3ecWYKgSyVZukGa1vVNmoxfHVCto9pzwBFp+eH302eVnhz947hl9yzHUja W5O64rK0/6PCZka93HYiv9kygaTGbaKfVu5mrkdXhVvDjsGj8OgEIOutYWRUObcc2aUn pQRv0sbCVurNnkqfJTa7faWSf0xNKxKqDmY7T9P33KGGKfXioy3uYTEYuVoQcu17dxSn rISVuw1JG7CaQjqyVyl9SQYPb2ZFXsc7RRcdko2pT21BRzX03jx5dBDJO0EHiw3c2RoE n5sSI2y483Y9RzNzmQeV9z1UsJoa5DmHJXY0gg6OlXaBsCvAYT8asOBG2kN/k3kNfBM3 zHoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=s29TMMaPCeov6Umv4/RKkhW1ulUvZ0bFNKT+MfZefKc=; b=GfetdebZdh21/TaxfFlac2pdPfRG6RHGs5uGVq8fWoMGgfSY7QdRCmeCbaKfZ6/DAF XWbKxcDqPs3Ga++Eoz02+UX3kIp2dsmzOoDXAP1pFhjfzqGr9rJoNx1x4ymXG8DZxZ60 hT1zlSlcVGEAu60aj79Y4NSqhvTNZWTCosHgNhZA8L4lRXJqgBgH0oxi5FenBiBVVolx ND4C3WfhCRjcrneMtWqelZ2uB/Vr1YuThR4ELWzbECufgDdQk3K92xgdYSTUa8MHBxcw 3jKq55J8mmaJCB1zy1TxwG6yofzH0woxeSdnMHYUrWt5yP32Jc1cCkIZMoozzeR8JcjT JG3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=jEmQGXjx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id eb10-20020a0564020d0a00b00425c429aa93si25537106edb.334.2022.05.25.11.21.27; Wed, 25 May 2022 11:21:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=jEmQGXjx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245558AbiEYQ7L (ORCPT + 99 others); Wed, 25 May 2022 12:59:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245528AbiEYQ7F (ORCPT ); Wed, 25 May 2022 12:59:05 -0400 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7791A9CC98; Wed, 25 May 2022 09:59:04 -0700 (PDT) Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24PGwhlc027029; Wed, 25 May 2022 16:59:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=pp1; bh=s29TMMaPCeov6Umv4/RKkhW1ulUvZ0bFNKT+MfZefKc=; b=jEmQGXjx15Ng6AVbzjonQGKGmIUemdi4xQjoqcOj5gAd7pUAhrMHvcsUGxAQKXudHRud vbd/H4hgyiebV2jNXJ75l4YBfqQyCycmzDjL3gL1wVZdQL7lZGzThI12mjnw15cf5zxx ZSv/+KUoefOl0c2yRMzGOVioAZcb1eDDqW69005wnElYHa4UlSvBYPihniPMpL1Yz3DE qqlK88jB0IANFtqkJpBcPlquEmg3n2Ui2dKQ8Yw9IYrFkV4p/8Qtl1XmydxXld+mZc8J uwz2uIcp/auspVq8RiKbTd5M1ma8L32yi41MvJ4qOQZbdtvGkj2NVpZErEs+nOt9wYeu TQ== Received: from ppma04wdc.us.ibm.com (1a.90.2fa9.ip4.static.sl-reverse.com [169.47.144.26]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3g9rewr063-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 25 May 2022 16:59:01 +0000 Received: from pps.filterd (ppma04wdc.us.ibm.com [127.0.0.1]) by ppma04wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 24PGcUfD032753; Wed, 25 May 2022 16:59:01 GMT Received: from b01cxnp23032.gho.pok.ibm.com (b01cxnp23032.gho.pok.ibm.com [9.57.198.27]) by ppma04wdc.us.ibm.com with ESMTP id 3g93uyqbb0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 25 May 2022 16:59:01 +0000 Received: from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com [9.57.199.109]) by b01cxnp23032.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 24PGx0nM27263316 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 May 2022 16:59:00 GMT Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D5F9B112061; Wed, 25 May 2022 16:59:00 +0000 (GMT) Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 468C1112062; Wed, 25 May 2022 16:59:00 +0000 (GMT) Received: from v0005c16.aus.stglabs.ibm.com (unknown [9.211.60.201]) by b01ledav004.gho.pok.ibm.com (Postfix) with ESMTP; Wed, 25 May 2022 16:59:00 +0000 (GMT) From: Eddie James To: broonie@kernel.org Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Eddie James Subject: [PATCH 2/2] spi: core: Display return code when failing to transfer message Date: Wed, 25 May 2022 11:58:52 -0500 Message-Id: <20220525165852.33167-3-eajames@linux.ibm.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220525165852.33167-1-eajames@linux.ibm.com> References: <20220525165852.33167-1-eajames@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: crbBxFRBBMklhPjWNlhgQ79uF7ygIQn4 X-Proofpoint-GUID: crbBxFRBBMklhPjWNlhgQ79uF7ygIQn4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-25_04,2022-05-25_02,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 mlxlogscore=999 spamscore=0 bulkscore=0 adultscore=0 clxscore=1015 phishscore=0 mlxscore=0 lowpriorityscore=0 malwarescore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2205250085 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org All the other calls to the controller driver display the error return code. The return code is helpful to understand what went wrong, so include it when failing to transfer one message. Signed-off-by: Eddie James --- drivers/spi/spi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 481edea77c62..ea09d1b42bf6 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -1654,7 +1654,8 @@ static void __spi_pump_messages(struct spi_controller *ctlr, bool in_kthread) ret = ctlr->transfer_one_message(ctlr, msg); if (ret) { dev_err(&ctlr->dev, - "failed to transfer one message from queue\n"); + "failed to transfer one message from queue: %d\n", + ret); goto out; } -- 2.27.0