Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp3983217ioo; Wed, 25 May 2022 12:06:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJydKchxNqDg7vxvdjN/o7R8wcQwJdXbg7Um20aSc9MGt03kSAF/PMte3wpXOsUhn6HMM1pa X-Received: by 2002:a17:903:11c7:b0:154:b936:d1d4 with SMTP id q7-20020a17090311c700b00154b936d1d4mr34170915plh.78.1653505591107; Wed, 25 May 2022 12:06:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653505591; cv=none; d=google.com; s=arc-20160816; b=rv8IIJ5P/3RryuqGhCsczS7euAUbRkwMgIb9nh7BBHE5ulbl9s9qo93SedN3Y0ZLj7 M4UVgnv+3E/4d9o3jdrQ2OLjkI8NBy3V6/TtPRwjsWnfLuaFQ4CCVuyVWEWKdLNrTGZ6 GgxYHMk53Jb5jEnyC41ButChs/qAK6CXSlMh+/dON/mkmLIvdvYsPEWG6OrCa0WbE64o FWDyKXCU5/sWTn9Yps1/Q7eq2Eo4RDQzzYxLk+IMV3+X11Dcr4ZeSXixStKW2L4q0pz4 pStlX6tPgwZZ/FDoyLaqwdsWD2x3F6/YT2P+sa7j3r93c4LCSlcg5QN8fb0jw2lNsBPy jGDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=nCNfEzGqMIoFCilTHapRIVeS9mBRmJZJ0gWnXehqDrw=; b=n5jeVgtVlfXsfLW8mzaB13TLgLdP+EkH/oI6gHTMfT9hiTgZR+zVqs5+KwEdSmtYi9 flENtv8Cx2936KtPsIDL/QHc+CL9IIvxK/J/w4i+Hc2NO+uOnhug5jMqFMwVvMHjj0RI xGVKzDtVzQTIrEQlTzb4ziBH3q4vhVV50yxqKJovMYv85k5YPMejquXhISnSHPbDfAyS UAVaGv19nUwKdy78yuGWZoxWOp64a0p0rsYdqJ/wT5kad8ULqYFRP6xK+t0TTz9IEUY7 f9ueezKRFV9CTg6+0Fsl1xQ9LNKkjdyBx1n54FIYAZjksVKxnuXqB/F9qOjDCliyi6Ar V1qg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=KKorYnAd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a186-20020a6390c3000000b003a1d18a5386si18210668pge.17.2022.05.25.12.06.16; Wed, 25 May 2022 12:06:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=KKorYnAd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242978AbiEYLoj (ORCPT + 99 others); Wed, 25 May 2022 07:44:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242936AbiEYLoi (ORCPT ); Wed, 25 May 2022 07:44:38 -0400 Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCCE8A204F for ; Wed, 25 May 2022 04:44:36 -0700 (PDT) Received: by mail-pg1-x52a.google.com with SMTP id s68so2396030pgs.10 for ; Wed, 25 May 2022 04:44:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=nCNfEzGqMIoFCilTHapRIVeS9mBRmJZJ0gWnXehqDrw=; b=KKorYnAd9m8FFqkZWn1KRNBoG7l7TplARvR9C9P62KHQROZ+jCx3jrm3pqL/gal3c9 tFxlYeVI5en3DpBcz9uCwkckr9YIthe+s0N26u6nJlmW2jp2woFwMCKEv8tbOJ6Ue3TI WbS9a4byWlYC8V9D8SCd2meKPqDE/U0FTn5968T/hQciYJlyiEq9tZ94pXPADWkvFk0j eBCLDxzMmIeDgmSoxpS+Db6wfsGf6U2Vh4SNWSSt6qCjruPdllqx+6OFrhWa3ZcNnszL b/ePL8Ohf4qX+HlckCZ2au3uCxyAFMSgsiIR8AcKFf1o7nK3X+9eTEmBH7FOmpCbJ/vp WKyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nCNfEzGqMIoFCilTHapRIVeS9mBRmJZJ0gWnXehqDrw=; b=nwSbq9ePTqdumSStETveLbTsFt0MBwLtoGSpcVvjYqxYPfwW563YR7tcnQEhJoFe9S YqjzT53IINEXiRNGYv/xHu0TxhnrVqYLgnsXUi5s76BT2DILW8iIyJ+YHexz+2dwYHqK f2T4kztXWuw04dVC3O8Rvuak1BJMxU6KsS6XCI5oeVYpab4Fu2HWVFgdUGVlZggh+0Sa N6rh+sfntHqE+duAJO7xXqjtbvvCZA0/KYubfn4qL6Wu+wCZ2hh24P1AK8+T7F4/IAoR dom8P2SjhVxY/LMlUx3xNQHOgUGU0a1+E9fPTSWEX+dLYtix64QKNsxZ2BaqColpb+LP vu5g== X-Gm-Message-State: AOAM530/R4G30MPvHIODX938MhDgr/CjNrHTLk2BKVCyRU4IzoTsicmD cEOsX7ws8V7W9Ot8BacqynAjXA== X-Received: by 2002:a05:6a00:2353:b0:518:96b7:ceb8 with SMTP id j19-20020a056a00235300b0051896b7ceb8mr16934713pfj.5.1653479076348; Wed, 25 May 2022 04:44:36 -0700 (PDT) Received: from localhost ([2408:8207:18da:2310:c40f:7b5:4fa8:df3f]) by smtp.gmail.com with ESMTPSA id u22-20020a17090ae01600b001df666ebddesm1406580pjy.6.2022.05.25.04.44.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 May 2022 04:44:36 -0700 (PDT) Date: Wed, 25 May 2022 19:44:31 +0800 From: Muchun Song To: Roman Gushchin Cc: hannes@cmpxchg.org, mhocko@kernel.org, shakeelb@google.com, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, duanxiongchun@bytedance.com, longman@redhat.com Subject: Re: [PATCH v4 06/11] mm: thp: make split queue lock safe when LRU pages are reparented Message-ID: References: <20220524060551.80037-1-songmuchun@bytedance.com> <20220524060551.80037-7-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 24, 2022 at 07:54:35PM -0700, Roman Gushchin wrote: > On Tue, May 24, 2022 at 02:05:46PM +0800, Muchun Song wrote: > > Similar to the lruvec lock, we use the same approach to make the split > > queue lock safe when LRU pages are reparented. > > > > Signed-off-by: Muchun Song > > Please, merge this into the previous patch (like Johannes asked > for the lruvec counterpart). > Will do in v5. > And add: > Acked-by: Roman Gushchin . > Thanks Roman.