Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <10ce14c0-f502-4c26-3f7a-8f470822e6f3@gmx.de>
Date:   Wed, 25 May 2022 14:17:39 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH] xen: remove setting of 'transp' parameter
Content-Language: en-US
To:     Tom Rix <trix@redhat.com>, tzimmermann@suse.de, javierm@redhat.com,
        boris.ostrovsky@oracle.com, jgross@suse.com
Cc:     linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20220521195942.645048-1-trix@redhat.com>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <20220521195942.645048-1-trix@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 5/21/22 21:59, Tom Rix wrote:
> cppcheck reports
> [drivers/video/fbdev/xen-fbfront.c:226]: (style) Assignment of function =
parameter has no effect outside the function.
>
> The value parameter 'transp' is not used, so setting it can be removed.
>
> Signed-off-by: Tom Rix <trix@redhat.com>

applied to the fbdev tree.
Thanks!
Helge

> ---
>  drivers/video/fbdev/xen-fbfront.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen=
-fbfront.c
> index 3bed357a9870..4d2694d904aa 100644
> --- a/drivers/video/fbdev/xen-fbfront.c
> +++ b/drivers/video/fbdev/xen-fbfront.c
> @@ -223,7 +223,6 @@ static int xenfb_setcolreg(unsigned regno, unsigned =
red, unsigned green,
>  	red =3D CNVT_TOHW(red, info->var.red.length);
>  	green =3D CNVT_TOHW(green, info->var.green.length);
>  	blue =3D CNVT_TOHW(blue, info->var.blue.length);
> -	transp =3D CNVT_TOHW(transp, info->var.transp.length);
>  #undef CNVT_TOHW
>
>  	v =3D (red << info->var.red.offset) |