Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp4011124ioo; Wed, 25 May 2022 12:48:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy9jbwGa0Loui7bxsgUBHabx27/cw/JnrREtdVOOQ/P4ye/RhfmZ2WV+ASil/ifAVYs8Be0 X-Received: by 2002:a17:90a:7026:b0:1df:4b6b:53d9 with SMTP id f35-20020a17090a702600b001df4b6b53d9mr12211601pjk.157.1653508082878; Wed, 25 May 2022 12:48:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653508082; cv=none; d=google.com; s=arc-20160816; b=Qua18jtZzqNDAT5oq05GV5tN1glE1b2Hcd2uBf7Uyesga0dr3LSFT71eSxHc3yclYb s0yYT6y8IS6H3/H7XdA0vyZLUKOTxBUnuCyfmkDMrRkf4gnrAY6TtGKYXOnx/rVi1sFr RqIp9ehALUDRVsaHQG5mkkrx+s44+wOA/QROBUKMh7DeZALrhA3CYRjfXwAZ76p7oi7k b04q3WRt29WLBl3bawKYZCLwq82gxTI7SHBqUId/oAepseOPcW/W4QvDuNs+/7WLLUn2 4HRP1jwqwiHabcPt/CHNB3Zve1tj3LyCQon4iP8X9Fx1vTjPsGn6zF4SKwUVjX2Zcqd4 jJLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=oQoa0hxtp2aLppBonjbRDOp8064Y/JajbFbLccXWRXs=; b=qAMX0WVGQR/bIslCOKMvxk14N+DO+zZ4F9LvBvHELlzbJIIEUzP5NnyU4SI/nUYexa T+bMdAzXoCVes+dGI/mqs5ty+hVmP8UuhUHRXPe4ykGHQwH9c8Nq7920Bfb9QXDaODXX +pAmxanRdnzZaNoSwHAcnUfNiNlRrMrH6IuDh5fwdl9R6l3luO783poMfNUdPDS4IeK3 8zBPvCTBU1Sxotzl22BXq2zV11kkEXf/lvP6cW1t4KYTrgo1zyiBvLNQWNn2l1NQELye mbBh+1QFi1IVKnCHzGBew7lOKpz0WvzzK2r0NMDwqIUOgU3uvlAe0nUSVEYWq8PRId49 r+YQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=WM8Bg2Iq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s1-20020a17090a880100b001e095e816c8si3044841pjn.26.2022.05.25.12.47.49; Wed, 25 May 2022 12:48:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=WM8Bg2Iq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239425AbiEYK7w (ORCPT + 99 others); Wed, 25 May 2022 06:59:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234445AbiEYK7s (ORCPT ); Wed, 25 May 2022 06:59:48 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 60E905F8C9 for ; Wed, 25 May 2022 03:59:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653476386; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=oQoa0hxtp2aLppBonjbRDOp8064Y/JajbFbLccXWRXs=; b=WM8Bg2Iq4Opu0D+BGzIbpPxMRt3H1wYzHx8hWotHsTwDEdNf6QZqdWWVPIzCnPTDT5Q9Jz RO+9j/rtxhNlvZe9CtagQjlNDW4EF6JdvXLo+36kMGk9kkVt5fXjUjsLRu2xyDkrIZv1ut 3DzRqdPPYY4U8hvJFECPnehjGtV/NIM= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-39-Wbiuid1DNn2z-eOkMf5Tzg-1; Wed, 25 May 2022 06:59:42 -0400 X-MC-Unique: Wbiuid1DNn2z-eOkMf5Tzg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D96EF1C0CE63; Wed, 25 May 2022 10:59:40 +0000 (UTC) Received: from eperezma.remote.csb (unknown [10.39.192.180]) by smtp.corp.redhat.com (Postfix) with ESMTP id 05E591730C; Wed, 25 May 2022 10:59:31 +0000 (UTC) From: =?UTF-8?q?Eugenio=20P=C3=A9rez?= To: "Michael S. Tsirkin" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, Jason Wang Cc: Zhu Lingshan , martinh@xilinx.com, Stefano Garzarella , ecree.xilinx@gmail.com, Eli Cohen , Dan Carpenter , Parav Pandit , Wu Zongyong , dinang@xilinx.com, Christophe JAILLET , Xie Yongji , gautam.dawar@amd.com, lulu@redhat.com, martinpo@xilinx.com, pabloc@xilinx.com, Longpeng , Piotr.Uminski@intel.com, tanuj.kamde@amd.com, Si-Wei Liu , habetsm.xilinx@gmail.com, lvivier@redhat.com, Zhang Min , hanand@xilinx.com Subject: [PATCH v3 0/4] Implement vdpasim stop operation Date: Wed, 25 May 2022 12:59:18 +0200 Message-Id: <20220525105922.2413991-1-eperezma@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Implement stop operation for vdpa_sim devices, so vhost-vdpa will offer=0D that backend feature and userspace can effectively stop the device.=0D =0D This is a must before get virtqueue indexes (base) for live migration,=0D since the device could modify them after userland gets them. There are=0D individual ways to perform that action for some devices=0D (VHOST_NET_SET_BACKEND, VHOST_VSOCK_SET_RUNNING, ...) but there was no=0D way to perform it for any vhost device (and, in particular, vhost-vdpa).=0D =0D After the return of ioctl with stop !=3D 0, the device MUST finish any=0D pending operations like in flight requests. It must also preserve all=0D the necessary state (the virtqueue vring base plus the possible device=0D specific states) that is required for restoring in the future. The=0D device must not change its configuration after that point.=0D =0D After the return of ioctl with stop =3D=3D 0, the device can continue=0D processing buffers as long as typical conditions are met (vq is enabled,=0D DRIVER_OK status bit is enabled, etc).=0D =0D In the future, we will provide features similar to VHOST_USER_GET_INFLIGHT_= FD=0D so the device can save pending operations.=0D =0D Comments are welcome.=0D =0D v3:=0D * s/VHOST_STOP/VHOST_VDPA_STOP/=0D * Add documentation and requirements of the ioctl above its definition.=0D =0D v2:=0D * Replace raw _F_STOP with BIT_ULL(_F_STOP).=0D * Fix obtaining of stop ioctl arg (it was not obtained but written).=0D * Add stop to vdpa_sim_blk.=0D =0D Eugenio P=C3=A9rez (4):=0D vdpa: Add stop operation=0D vhost-vdpa: introduce STOP backend feature bit=0D vhost-vdpa: uAPI to stop the device=0D vdpa_sim: Implement stop vdpa op=0D =0D drivers/vdpa/vdpa_sim/vdpa_sim.c | 21 +++++++++++++++++=0D drivers/vdpa/vdpa_sim/vdpa_sim.h | 1 +=0D drivers/vdpa/vdpa_sim/vdpa_sim_blk.c | 3 +++=0D drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 3 +++=0D drivers/vhost/vdpa.c | 34 +++++++++++++++++++++++++++-=0D include/linux/vdpa.h | 6 +++++=0D include/uapi/linux/vhost.h | 14 ++++++++++++=0D include/uapi/linux/vhost_types.h | 2 ++=0D 8 files changed, 83 insertions(+), 1 deletion(-)=0D =0D -- =0D 2.27.0=0D =0D