Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 25 May 2022 08:33:38 +0200
From:   Andreas Klinger <ak@it-klinger.de>
To:     Li Zhengyu <lizhengyu3@huawei.com>
Cc:     jic23@kernel.org, lars@metafoo.de, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: srf08: Remove redundant if statement
Message-ID: <Yo3Nwnq58tjKp3nl@arbad>
References: <20220523122755.90638-1-lizhengyu3@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220523122755.90638-1-lizhengyu3@huawei.com>
Precedence: bulk

Acked-by: Andreas Klinger <ak@it-klinger.de>

Li Zhengyu <lizhengyu3@huawei.com> schrieb am Mo, 23. Mai 20:27:
> (!val) has been checked outside the loop, remove redundant (val &&)
> from loop.
> 
> Signed-off-by: Li Zhengyu <lizhengyu3@huawei.com>
> ---
>  drivers/iio/proximity/srf08.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/proximity/srf08.c b/drivers/iio/proximity/srf08.c
> index ac1ab7e89d4e..7ed11339c31e 100644
> --- a/drivers/iio/proximity/srf08.c
> +++ b/drivers/iio/proximity/srf08.c
> @@ -354,7 +354,7 @@ static ssize_t srf08_write_sensitivity(struct srf08_data *data,
>  		return -EINVAL;
>  
>  	for (i = 0; i < data->chip_info->num_sensitivity_avail; i++)
> -		if (val && (val == data->chip_info->sensitivity_avail[i])) {
> +		if (val == data->chip_info->sensitivity_avail[i]) {
>  			regval = i;
>  			break;
>  		}
> -- 
> 2.17.1
> 

-- 
Andreas Klinger
Grabenreith 27
84508 Burgkirchen
+49 8623 919966
ak@it-klinger.de
www.it-klinger.de
www.grabenreith.de