Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp4017938ioo; Wed, 25 May 2022 12:59:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwiV+Wjjn113TK4E1YVrephFPF30A1P7XslhZnD1HUFa/DLkAyNPHrIVUizyniUc+pH5Cqd X-Received: by 2002:a63:488:0:b0:3f5:e6da:4619 with SMTP id 130-20020a630488000000b003f5e6da4619mr29815053pge.6.1653508774843; Wed, 25 May 2022 12:59:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653508774; cv=none; d=google.com; s=arc-20160816; b=SEmFGzvlmdnzIIPbtCQayV+gBwh8PVaxW9ImJdCrc29bWFIHZqpxVqbElr2uOjtiO0 lowctLCOzvZFq/wHnDo5CBX5coUWimQKlB6oXuXRsppd6O655zhWOwdqlfxuVCQP2/0+ oQ29kquetMlgi8vKParc9x9/LXbvUrzBMYjIF2hHTFBa/CHg/Kwck1AR0ZAs34pahzq1 9gxdB0O1fRmJiXkJSFIcZ84C6+udHfvpGSBbbkzkvd7941KRwBWXMuGM8ltf7g/rskkK 3CxB7daL5W+H8nnRaUgaQIb49SanIp2YLNLWP6zexIwPssIvcxhs84qXAkrkT7vW8Euk NkLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=TKu3jDxR1qyaoZyxQd8Ts5G700gfE4pahytHEbPkEuo=; b=TgrDXuUVHCmZ8kfO+JQtFRiarXfNvYt3/tyl63ehTCS3IXHluEGMMIUtVKYEA15Li9 LDikmA6Erdas83POyX3JTztKi4JDnpa80E4epE1hnPERK7sbl4nUwnctVMq9DjNO8YRu iO2Y8x0FGXkPIKFaxNneVoicrfGzYPAW4UGXScnYIYUOj/uvshU5DEcNuq04cKn4m1ay MuTXUQoQDC4lFXaYJArnUp1Frt3kMmuQG8HgQhJhDJ54tVpvRfnWX/qPPRbihiOHCzjk IQCmIQy8/PGH+uRCWLiSEDLfV6gxMx40We80T+HIt5QFNM0V6IO1vtFieHdVc7TB5Cvh +LNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=GXtzlSsV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id oj8-20020a17090b4d8800b001df4c5057b8si3825882pjb.51.2022.05.25.12.59.23; Wed, 25 May 2022 12:59:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=GXtzlSsV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237305AbiEYNZY (ORCPT + 99 others); Wed, 25 May 2022 09:25:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244434AbiEYNZN (ORCPT ); Wed, 25 May 2022 09:25:13 -0400 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D25902B1B4 for ; Wed, 25 May 2022 06:25:12 -0700 (PDT) Received: by mail-pj1-x1033.google.com with SMTP id fw21-20020a17090b129500b001df9f62edd6so4070738pjb.0 for ; Wed, 25 May 2022 06:25:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=TKu3jDxR1qyaoZyxQd8Ts5G700gfE4pahytHEbPkEuo=; b=GXtzlSsV72DJ4r7qA3ECNDCXmSDzD8JR+b7SloEDQLdYm1Ra/ZpSJk2ACoplR9lw4J 8fqymQa/ZL0HYinpuFgcXOXxZRd/zF6n72jKlTNQRV9dpq0D6UX0i5on8X/oNtwuLC5U iIK1AyD1hM2JWl5CiM8yckZo7u1n/GdB7j5wbub/+rF3ww76dZXgPymJMPnltPFfmEZN VdpdZz/hpeiVxZRJPlgN/ztZasy+PLIfvkG2Flt3OQAQsyC9oeoKlO/F43PLMwyyQ9P+ Pp/9Nvh9eIkub2B8hVSz6WjmJmTsOHnQE4BMc+/lXsld8wAiPyWgPyTTY1qr0q/iz8vf 11tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=TKu3jDxR1qyaoZyxQd8Ts5G700gfE4pahytHEbPkEuo=; b=yp0mhrGsb35ZLXtZ/gEykCsWyAIvlCRtkox33Xwlg7Dy0SWFK2S0i/BTsUBgFbQVuX SYb5DMf/KzVXipdkJG/d88JPtSEf7Tag5jzG5L37h0Rk99Gc65IUQWUG4IdtMdgdt885 kbNgz0fBeqJFLK/IGMTjsxz5jpX2P+O6fmSuO4GtbN6PMnesv82DOmVxTpnTtQeMNRT3 aOoO1Bdd9vl3oCzGFaQP4N8teBVjePGZ63RHirCMwDXRd9nTdwEDmW6kY0nZuHH6ixFm 5xwF1kdo8pP/VPORROVJM+tGZ8YOuplNFZ5HSHqrwC26YVt7VsFaxv1Ql1eXve2J0HGp XNNg== X-Gm-Message-State: AOAM530OAlB+P/A9a3Q88U4b2UHD8AjMegQ9LlDim+iQhOiWq+WtMtGA 8WkYX2JB8LzmOu3qcshCiWAC69HjAv8rmg== X-Received: by 2002:a17:902:eb4d:b0:15e:d25c:4e0a with SMTP id i13-20020a170902eb4d00b0015ed25c4e0amr33288707pli.8.1653485112355; Wed, 25 May 2022 06:25:12 -0700 (PDT) Received: from localhost ([2408:8207:18da:2310:c40f:7b5:4fa8:df3f]) by smtp.gmail.com with ESMTPSA id d17-20020a170903209100b0015e8e7db067sm9225346plc.4.2022.05.25.06.25.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 May 2022 06:25:12 -0700 (PDT) Date: Wed, 25 May 2022 21:25:07 +0800 From: Muchun Song To: Baolin Wang Cc: mike.kravetz@oracle.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/hugetlb: Remove unnecessary huge_ptep_set_access_flags() in hugetlb_mcopy_atomic_pte() Message-ID: References: <7cd55152c1a00910afda570d1543a97198b3665b.1653468078.git.baolin.wang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7cd55152c1a00910afda570d1543a97198b3665b.1653468078.git.baolin.wang@linux.alibaba.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 25, 2022 at 06:26:24PM +0800, Baolin Wang wrote: > There is no need to update the hugetlb access flags after just setting the > hugetlb page table entry by set_huge_pte_at(), since the page table entry > value has no changes. Thus remove the unnecessary huge_ptep_set_access_flags() > in hugetlb_mcopy_atomic_pte(). > > Signed-off-by: Baolin Wang Reviewed-by: Muchun Song Thanks.