Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 25 May 2022 12:17:31 +0530
From:   Viresh Kumar <viresh.kumar@linaro.org>
To:     Tang Bin <tangbin@cmss.chinamobile.com>
Cc:     vireshk@kernel.org, nm@ti.com, sboyd@kernel.org,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] opp: Fix error check in dev_pm_opp_attach_genpd()
Message-ID: <20220525064731.k4lgjrcu355b73q6@vireshk-i7>
References: <20220524123151.1416-1-tangbin@cmss.chinamobile.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220524123151.1416-1-tangbin@cmss.chinamobile.com>
Precedence: bulk

On 24-05-22, 20:31, Tang Bin wrote:
> dev_pm_domain_attach_by_name() may return NULL in some cases,
> so IS_ERR() doesn't meet the requirements. Thus fix it.
> 
> Fixes: 6319aee10e53 ("opp: Attach genpds to devices from within OPP core")
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> ---
>  drivers/opp/core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/opp/core.c b/drivers/opp/core.c
> index 2945f3c1c..56cae6ee2 100644
> --- a/drivers/opp/core.c
> +++ b/drivers/opp/core.c
> @@ -2409,8 +2409,8 @@ struct opp_table *dev_pm_opp_attach_genpd(struct device *dev,
>  		}
>  
>  		virt_dev = dev_pm_domain_attach_by_name(dev, *name);
> -		if (IS_ERR(virt_dev)) {
> -			ret = PTR_ERR(virt_dev);
> +		if (IS_ERR_OR_NULL(virt_dev)) {
> +			ret = PTR_ERR(virt_dev) ? : -ENODATA;

I have changed this to ENODEV instead.

>  			dev_err(dev, "Couldn't attach to pm_domain: %d\n", ret);
>  			goto err;
>  		}

Applied. Thanks.

-- 
viresh