Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762800AbXEPRij (ORCPT ); Wed, 16 May 2007 13:38:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758592AbXEPRib (ORCPT ); Wed, 16 May 2007 13:38:31 -0400 Received: from cantor2.suse.de ([195.135.220.15]:45242 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758538AbXEPRia (ORCPT ); Wed, 16 May 2007 13:38:30 -0400 Date: Wed, 16 May 2007 19:38:16 +0200 From: Nick Piggin To: Hugh Dickins Cc: Benjamin Herrenschmidt , linux-arch@vger.kernel.org, Andrew Morton , Linux Kernel Mailing List , Linux Memory Management List Subject: Re: [rfc] optimise unlock_page Message-ID: <20070516173816.GB5883@wotan.suse.de> References: <1178659827.14928.85.camel@localhost.localdomain> <20070508224124.GD20174@wotan.suse.de> <20070508225012.GF20174@wotan.suse.de> <20070510033736.GA19196@wotan.suse.de> <20070511085424.GA15352@wotan.suse.de> <20070513033210.GA3667@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1845 Lines: 41 On Wed, May 16, 2007 at 06:21:09PM +0100, Hugh Dickins wrote: > On Sun, 13 May 2007, Nick Piggin wrote: > > On Fri, May 11, 2007 at 02:15:03PM +0100, Hugh Dickins wrote: > > > > > But again I wonder just what the gain has been, once your double > > > unmap_mapping_range is factored in. When I suggested before that > > > perhaps the double (well, treble including the one in truncate.c) > > > unmap_mapping_range might solve the problem you set out to solve > > > (I've lost sight of that!) without pagelock when faulting, you said: > > > > > > > Well aside from being terribly ugly, it means we can still drop > > > > the dirty bit where we'd otherwise rather not, so I don't think > > > > we can do that. > > > > > > but that didn't give me enough information to agree or disagree. > > > > Oh, well invalidate wants to be able to skip dirty pages or have the > > filesystem do something special with them first. Once you have taken > > the page out of the pagecache but still mapped shared, then blowing > > it away doesn't actually solve the data loss problem... only makes > > the window of VM inconsistency smaller. > > Right, I think I see what you mean now, thanks: userspace > must not for a moment be allowed to write to orphaned pages. Yep. > Whereas it's not an issue for the privately COWed pages you added > the second unmap_mapping_range for: because it's only truncation > that has to worry about them, so they're heading for SIGBUS anyway. > > Yes, and the page_mapped tests in mm/truncate.c are just racy > heuristics without the page lock you now put into faulting. Yes. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/