Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Zi Yan <ziy@nvidia.com>
To:     Stephen Rothwell <sfr@canb.auug.org.au>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the mm tree
Date:   Wed, 25 May 2022 06:57:53 -0400
Message-ID: <6CA81704-417D-4843-940E-F901803A908C@nvidia.com>
In-Reply-To: <20220525155401.4a72ad6b@canb.auug.org.au>
References: <20220525155401.4a72ad6b@canb.auug.org.au>
Content-Type: multipart/signed;
 boundary="=_MailMate_B4925A09-6453-4FFD-99BE-7159977DFBFC_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZYZdICY5mkxvu0arT+I/tGZvnZHdir9lc4THM3khH93qVDSNWALsrNTC77l5?=
 =?us-ascii?Q?YPIC2khAeYMJzxf51ycZzYDFvRSpIyUIk9a74jHizOXySu8r/h5rQurAFDL6?=
 =?us-ascii?Q?P4yFlRolTuLaHxV7+6b5LOvVnE5GCn1vkm3O49/633YznNqokL9K1MCx66gL?=
 =?us-ascii?Q?2MpYEnXl51PKlOOsDyghQ++givbBl3jqfetRWzdTZJjFJVkTS950atpKTqho?=
 =?us-ascii?Q?YR5nRDXPbuL9juwH2vLzqW8a18YVgJjbiksULZ/IhL2fkjHOfW4RckwSHqLA?=
 =?us-ascii?Q?1y30vMs19t/tuBYuBHC8vXC1IYSKy/2zDfOtiSQsWBkOdVIZyqo9FOjTNRMd?=
 =?us-ascii?Q?bWRgpn0duMbUq4Kd89FvBIYnVrKvLKQvqb8KhmGp5RbZYeG9V/ZrHjPWI967?=
 =?us-ascii?Q?tpI0Z60qTrBlnPd4MdoH2tKWEFqyuix4YIgOtoigzSxnHQtfQCwQy1z2WsUH?=
 =?us-ascii?Q?4qUWgf2ku058TGjMc8sstVHZHD0QTYkYPgM8xpCuEdHeaTFbpLd8snAyX7wU?=
 =?us-ascii?Q?9lx2+AQSNO76mGAQ4NHrBQvmTOCw/alv25sU/KIkOY59txf7ur96M9I3ivVQ?=
 =?us-ascii?Q?kMfBh0mBIA1W5N/73ea5WI4sCy8WJ2uYjX2lO60G6f9nKgi/I8y9f6cQ08no?=
 =?us-ascii?Q?We1mNszIc5+MHGBwuVAbUYfkJAX3KO3vSmfsG3eHoV6guZ9hSGpqVCk04Kdi?=
 =?us-ascii?Q?e/C4jQDtv6AefVeD8Hk7vCnEOUGnQ0pm4xwDXxAumlqk7PaeStObQg/wCXQv?=
 =?us-ascii?Q?2YxHN6ESKzQoNUrjk2fg9Wjj4MbXTtr90OaY4SW9D0uYYWqMGyPk/u5EsGXs?=
 =?us-ascii?Q?CshlRpr7rZYX5n49cKdBmVxdbgEsZXjkSBmZfliX/s8xhcS22FIns258GCaI?=
 =?us-ascii?Q?Yp8aEu9bU13Xs46SH9C7ZvqvUrVck2E93tqYAX0ATrbFZ0JMDK4nALcxQ78z?=
 =?us-ascii?Q?9guvG5+wbhdzI6sAz/1iGzPMv4Tvpxq5rTlBsWKdYfyLSr1Q/59xHE9xd8s7?=
 =?us-ascii?Q?yajMRJCoSwTQ37+CFJTVbVm47gFGaH7lxkkiO8h0ZiVlVb6q40lMczXLyx5i?=
 =?us-ascii?Q?NrPP6K8D07gfyhyRciBLUfOK45K+jRPyRUnC0HelTsLR8bcOAmFAN6EzA1PW?=
 =?us-ascii?Q?dirlUfI2jRpS2E7C/B6uvGMZoCJrWTOPk7Yj2YvdjP7qc9Ap1JL9ww/8ypTN?=
 =?us-ascii?Q?lo2wm1ViDTXqZz/MsPbHS3S1EmcVAG7Ke3fi/6xDbvU842f6Mc5kdZIQH39D?=
 =?us-ascii?Q?7GH/um8mgOuEZYxJJd6nqY+wBI5/u1AIcdeY0A+QEhx2dESztukdmNMCUfrb?=
 =?us-ascii?Q?Cvs/QbG13Zn/2TmWb/hWR9rZHUiTuY1PLfUSmaoGr8yuMhcb2DyhTRjxMxik?=
 =?us-ascii?Q?g/SSU8/Dv9RU8LiyhFoWwh/xqkVEXwaoyZT4AE3CzUBJUPY4pK8BV1whtA+S?=
 =?us-ascii?Q?VbXCJIUezEnChiegmIlcCH4eMST8Zgsb3X5TPKT3uRVrxC8Puwjo/URb547h?=
 =?us-ascii?Q?g7uRFZ5xHaUl46ZbfTPW/Mvryek27HjRdl3/QcKZ+twp+MqrlNL2EOBc0nQO?=
 =?us-ascii?Q?mMhNjjJZEjrCrUU6zXwrGNs+RLeeaphVs+qpjT1VcZ2Dga8ZO8xhHAS5Y3NU?=
 =?us-ascii?Q?m7Kn5cwOZGRF9J4niCEK4/W+/7MmSQoDqZsEWKZKisgCHAgjvXkD4S3n27Y0?=
 =?us-ascii?Q?w9VTH6EgA5IxwurRFZqaY9IL10UGV7LM5o9ku9tAO6WpXmR05wuHZO9TxkOv?=
 =?us-ascii?Q?XmIyFPp0xA=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b981e2e-7711-4163-f60f-08da3e3d6c09
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2022 10:57:55.4740
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vmPSlerqRBML4M1EaPnlZnGqSikBNIg+7pksvc1Wxtf6wr5pOk0dXFx9JTD0Te97
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3081
X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--=_MailMate_B4925A09-6453-4FFD-99BE-7159977DFBFC_=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On 25 May 2022, at 1:54, Stephen Rothwell wrote:

> Hi all,
>
> After merging the mm tree, today's linux-next build (sparc64 defconfig)=

> produced this warning:
>
> In file included from include/linux/kernel.h:26,
>                  from include/linux/cpumask.h:10,
>                  from include/linux/smp.h:13,
>                  from include/linux/lockdep.h:14,
>                  from include/linux/spinlock.h:62,
>                  from include/linux/mmzone.h:8,
>                  from include/linux/gfp.h:6,
>                  from include/linux/mm.h:7,
>                  from mm/page_alloc.c:19:
> mm/page_alloc.c: In function 'split_free_page':
> include/linux/minmax.h:20:35: warning: comparison of distinct pointer t=
ypes lacks a cast
>    20 |         (!!(sizeof((typeof(x) *)1 =3D=3D (typeof(y) *)1)))
>       |                                   ^~
> include/linux/minmax.h:26:18: note: in expansion of macro '__typecheck'=

>    26 |                 (__typecheck(x, y) && __no_side_effects(x, y))
>       |                  ^~~~~~~~~~~
> include/linux/minmax.h:36:31: note: in expansion of macro '__safe_cmp'
>    36 |         __builtin_choose_expr(__safe_cmp(x, y), \
>       |                               ^~~~~~~~~~
> include/linux/minmax.h:45:25: note: in expansion of macro '__careful_cm=
p'
>    45 | #define min(x, y)       __careful_cmp(x, y, <)
>       |                         ^~~~~~~~~~~~~
> mm/page_alloc.c:1138:35: note: in expansion of macro 'min'
>  1138 |                 free_page_order =3D min(pfn ? __ffs(pfn) : orde=
r, __fls(split_pfn_offset));
>       |                                   ^~~
>
> Introduced by commit
>
>   29a8af92b874 ("mm: fix a potential infinite loop in start_isolate_pag=
e_range()")

Hi Stephen,

The patch below should fix it:

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 6eec0211e0be..dbbfe4a079d3 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1123,7 +1123,9 @@ void split_free_page(struct page *free_page,
             pfn < free_page_pfn + (1UL << order);) {
                int mt =3D get_pfnblock_migratetype(pfn_to_page(pfn), pfn=
);

-               free_page_order =3D min(pfn ? __ffs(pfn) : order, __fls(s=
plit_pfn_offset));
+               free_page_order =3D min_t(unsigned long,
+                                       pfn ? __ffs(pfn) : order,
+                                       __fls(split_pfn_offset));
                __free_one_page(pfn_to_page(pfn), pfn, zone, free_page_or=
der,
                                mt, FPI_NONE);
                pfn +=3D 1UL << free_page_order;

--
Best Regards,
Yan, Zi

--=_MailMate_B4925A09-6453-4FFD-99BE-7159977DFBFC_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmKOC7EPHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhUXKkQAJgxJ8zqF3IOtBitI21EXjdirYrgcBbvdrhM
cXE4vp6KnbxpYCEUN7A8IcnD5U37jPOXzgm+WEQW25AmWbmomWsJ1aZm7k3O7xyr
WMTFjgVeKBfZKIg1a1Cu+dkU2Z1o5c/f7+vb29rHeuaa9GyVh6qvpsBLZdUcW25y
5/Jp5gyo6x9O+TGTjETEnA8oH9HvNiUOqIhROQipIzn3yyigLypA9RUCgQulx09V
k6M9TSwn8d7axBniAajuQvqJlCW6ZKzd9/EPxVijEOGOtkRNB+C/NN0/Liy3KAvC
7y9WSYBxl3j3GGsne6l+WfI/7nZT0mQBcRkKS28ysaq+f3iprI4F971IuTRBt6Sm
eJwKi6xSSubZZjl4xzh4Gnxs3tz80HuTDJkW3AKTlUJgBHE4ZR286ElN+J+85dmD
BLhZxcb82vCqEjLTp3d1pRMg71Qz70AD1G1FpDDjldi+FxcKIg0WVs3chUd3lfwH
kErE45xqo+oVn8rTbpTxE6VJ+6o1egcoQ6vBvRlscpOjijqmjJOVLNyBVNwe9DOC
r/grEmLPrbA17/VAqjsuLPVLfz6z5ed4kuOJPlbmPsg+QaARPsDP0Gt39TnZGo7t
6CgFw951pTQBoNdge9BTaOMkEyy4+qVbnkuqd1XRUaMZZNLbCDYfDABB62j8jsl3
Jcma1QVc
=S0Ob
-----END PGP SIGNATURE-----

--=_MailMate_B4925A09-6453-4FFD-99BE-7159977DFBFC_=--