Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <853b6d52-da86-1c06-3604-3085ece331a4@huawei.com>
Date:   Wed, 25 May 2022 18:10:51 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH v2] coresight: etm4x: Add Support for HiSilicon ETM device
Content-Language: en-US
To:     Qi Liu <liuqi115@huawei.com>, <gregkh@linuxfoundation.org>,
        <mathieu.poirier@linaro.org>, <suzuki.poulose@arm.com>,
        <mike.leach@linaro.org>
CC:     <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <linuxarm@huawei.com>,
        <abudankov@huawei.com>,
        Alexey Budankov <alexey.budankov@huawei.com>
References: <1597323562-3706-1-git-send-email-liuqi115@huawei.com>
From:   Alexei Budankov <abudankov@huawei.com>
In-Reply-To: <1597323562-3706-1-git-send-email-liuqi115@huawei.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


Hi Qi Liu,

On 13.08.2020 15:59, Qi Liu wrote:
> Add ETMv4 periperhal ID for HiSilicon Hip08 and Hip09 platform. Hip08
> contains ETMv4.2 device and Hip09 contains ETMv4.5 device.
> 
> Signed-off-by: Qi Liu <liuqi115@huawei.com>
> ---
>   drivers/hwtracing/coresight/coresight-etm4x.c | 2 ++
>   1 file changed, 2 insertions(+)

Thanks for your patch.
I would like to test HiSilicon ETM device feature on
Kunpeng 920 based server.
I applied the patch and booted the kernel with the changes.
However I don't see any device files neither here:
/sys/bus/coresight/devices/
nor here:
/sys/bus/event_source/devices/cs_etm/sinks/
What should a user expect new in os with this patch added?

Thanks,
Alexei


> 
> diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c b/drivers/hwtracing/coresight/coresight-etm4x.c
> index 6d7d216..7797a57 100644
> --- a/drivers/hwtracing/coresight/coresight-etm4x.c
> +++ b/drivers/hwtracing/coresight/coresight-etm4x.c
> @@ -1587,6 +1587,8 @@ static const struct amba_id etm4_ids[] = {
>   	CS_AMBA_UCI_ID(0x000bb805, uci_id_etm4),/* Qualcomm Kryo 4XX Cortex-A55 */
>   	CS_AMBA_UCI_ID(0x000bb804, uci_id_etm4),/* Qualcomm Kryo 4XX Cortex-A76 */
>   	CS_AMBA_UCI_ID(0x000cc0af, uci_id_etm4),/* Marvell ThunderX2 */
> +	CS_AMBA_UCI_ID(0x000b6d01, uci_id_etm4),/* HiSilicon-Hip08 */
> +	CS_AMBA_UCI_ID(0x000b6d02, uci_id_etm4),/* HiSilicon-Hip09 */
>   	{},
>   };
> 
> --
> 2.8.1