Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20220523092314.14252-4-quic_tdas@quicinc.com>
References: <20220523092314.14252-1-quic_tdas@quicinc.com> <20220523092314.14252-4-quic_tdas@quicinc.com>
Subject: Re: [PATCH v2 3/3] clk: qcom: lpass: Add support for resets & external mclk for SC7280
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
        linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, robh@kernel.org, robh+dt@kernel.org,
        Taniya Das <quic_tdas@quicinc.com>
To:     Michael Turquette <mturquette@baylibre.com>,
        Taniya Das <quic_tdas@quicinc.com>
Date:   Wed, 25 May 2022 10:54:50 -0700
User-Agent: alot/0.10
Message-Id: <20220525175452.5FC9FC34113@smtp.kernel.org>
Precedence: bulk

Quoting Taniya Das (2022-05-23 02:23:14)
> diff --git a/drivers/clk/qcom/lpassaudiocc-sc7280.c b/drivers/clk/qcom/lp=
assaudiocc-sc7280.c
> index 6ab6e5a34c72..536509b78341 100644
> --- a/drivers/clk/qcom/lpassaudiocc-sc7280.c
> +++ b/drivers/clk/qcom/lpassaudiocc-sc7280.c
>  static const struct of_device_id lpass_audio_cc_sc7280_match_table[] =3D=
 {
>         { .compatible =3D "qcom,sc7280-lpassaudiocc" },
>         { }
> @@ -741,6 +754,8 @@ static int lpass_audio_cc_sc7280_probe(struct platfor=
m_device *pdev)
>                 return ret;
>         }
>=20
> +       ret =3D qcom_cc_probe_by_index(pdev, 1, &lpass_audio_cc_reset_sc7=
280_desc);

What if it fails? Shouldn't we pm_runtime_disable()?

> +
>         pm_runtime_mark_last_busy(&pdev->dev);
>         pm_runtime_put_autosuspend(&pdev->dev);
>         pm_runtime_put_sync(&pdev->dev);