Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3e686290-14e4-a4e9-3825-afb011b8c0e4@linux.dev>
Date:   Wed, 25 May 2022 07:20:40 +0300
MIME-Version: 1.0
From:   Vasily Averin <vasily.averin@linux.dev>
Subject: Re: [PATCH] ipc: Remove dead code in perform_atomic_semop()
Content-Language: en-US
To:     Gautam Menghani <gautammenghani201@gmail.com>,
        akpm@linux-foundation.org, shakeelb@google.com, mhocko@suse.com,
        manfred@colorfullife.com
Cc:     linux-kernel@vger.kernel.org,
        linux-kernel-mentees@lists.linuxfoundation.org,
        skhan@linuxfoundation.org
References: <20220524182244.42987-1-gautammenghani201@gmail.com>
 <a9cd5385-5a26-c410-2609-4575cc0d6adf@linux.dev>
In-Reply-To: <a9cd5385-5a26-c410-2609-4575cc0d6adf@linux.dev>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/25/22 02:12, vasily.averin@linux.dev wrote:
> On 5/24/22 21:22, Gautam Menghani wrote:
>> Remove the line which is dead code. Fixes the clang scan warning:
>> warning: Value stored to 'result' is never read [deadcode.DeadStores]
>>                 result = curr->semval;
>>
>> Signed-off-by: Gautam Menghani <gautammenghani201@gmail.com>
>> ---
>>  ipc/sem.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/ipc/sem.c b/ipc/sem.c
>> index 0dbdb98fdf2d..156824bcda47 100644
>> --- a/ipc/sem.c
>> +++ b/ipc/sem.c
>> @@ -766,7 +766,6 @@ static int perform_atomic_semop(struct sem_array *sma, struct sem_queue *q)
>>  	for (sop = sops; sop < sops + nsops; sop++) {
>>  		curr = &sma->sems[sop->sem_num];
>>  		sem_op = sop->sem_op;
>> -		result = curr->semval;
>>  
>>  		if (sop->sem_flg & SEM_UNDO) {
>>  			int undo = un->semadj[sop->sem_num] - sem_op;
> 
> Perhaps it would be better to keep the "result" but use it in the
> marked line below, like it was done in previous part of this function?

Sorry, I was wrong.
Reviewed-by: Vasily Averin <vvs@openvz.org>