Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp4171774ioo; Wed, 25 May 2022 17:16:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwiflLPmKgtBrY93wN3WcBsNGbcfmp23TGBdDkh/Jevibw8SYbr+Xc5vIULiNOU433o2TP8 X-Received: by 2002:aa7:d14b:0:b0:42b:ced3:df36 with SMTP id r11-20020aa7d14b000000b0042bced3df36mr4418778edo.258.1653524217003; Wed, 25 May 2022 17:16:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653524216; cv=none; d=google.com; s=arc-20160816; b=rMJ8Fw41lP9mHOtojUDmFZcTp2xf2+wsONUE2HoF5wpZLefeGKuVjp+ewU2VAmMNme OF76LmtW8qASS2o+a7Pd0MguEE1Cqcq4ELoI+783886FrGbxooqQpYSejNX76d5tmPa3 sahgjaYeyEJ4+puSgKMfjNqmXP5swQilPffXOp+aHKjwuLwsxeGR37aZX2GMkMSVOdbD JFHdbj6x5rk3YZszLpJlQ0dMC4lts+GD/4fMn62pglRzy1y1NcX1BpQaY1dQpf9eCcUa a+mxO4byYIgypuPnTe0Vdo7nlu6ukyGv27haLFl98yv43RFVLTKhHjIcWDkWyaJ5so1w zuKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:dkim-signature:date; bh=OVjueIe9mhvrA27ww7AR0v74gWv/I98eGtND8IZl3vg=; b=EWO7e0edESaYpUhf6Ih2d5CfMC/TxjpIBw8cEebC6vzyEh6k7MVVMkkR1Lms52C38O U2B/+CSlitk5xjeXMXyBM9Ho8BTfJV0oGck/ebPn3EnnYVonLac2tzrQBPhn8MjFxJuU 82QK5hL+/GZXsjlmyeBvlEME/3H6343PyHxlp/PdTv6MXz3nZqOGEVa9MalMbb+Adaxv Fg7D3ouLbMLns5eE9j40glxv89GrwM4Wp9QQsOEBpRgg19RMsFjCdXYqI87T9JXZMxh0 FMvzoqqzRNiWM96I3oMC+KPbssYJdYZntnn49iOkwuxS7zyuBIsmMTUTGv/XwrI3qEZG Z3Kg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=VyeEk+zQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fs20-20020a170907601400b006feff1cbe14si79922ejc.160.2022.05.25.17.16.31; Wed, 25 May 2022 17:16:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=VyeEk+zQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243209AbiEYBbV (ORCPT + 99 others); Tue, 24 May 2022 21:31:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243205AbiEYBbT (ORCPT ); Tue, 24 May 2022 21:31:19 -0400 Received: from out1.migadu.com (out1.migadu.com [91.121.223.63]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CE2412AF5; Tue, 24 May 2022 18:31:17 -0700 (PDT) Date: Tue, 24 May 2022 18:31:10 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1653442275; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OVjueIe9mhvrA27ww7AR0v74gWv/I98eGtND8IZl3vg=; b=VyeEk+zQVrAX1dIxFiZr77PDfHCvUjewxtS5IhtduYYDn5AqfvWy60/KZVUPwogYGH2TRW kTsnAIrSGT+1YJBn+jOgwjZRcYRaOargixCYaEvGQsgsk8LkNNJeTEwc4YfWesQ/W18lCL +/5ggn+QKpfcJrCA07Vjk4tVSQq3s68= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Vasily Averin Cc: Andrew Morton , kernel@openvz.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt , Michal =?iso-8859-1?Q?Koutn=FD?= , Vlastimil Babka , Michal Hocko , cgroups@vger.kernel.org Subject: Re: [PATCH mm v2 6/9] memcg: enable accounting for percpu allocation of struct cgroup_rstat_cpu Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 21, 2022 at 07:38:31PM +0300, Vasily Averin wrote: > struct cgroup_rstat_cpu is percpu allocated for each new cgroup and > can consume a significant portion of all allocated memory on nodes > with a large number of CPUs. > > Common part of the cgroup creation: > Allocs Alloc $1*$2 Sum Allocation > number size > -------------------------------------------- > 16 ~ 352 5632 5632 KERNFS > 1 + 4096 4096 9728 (cgroup_mkdir+0xe4) > 1 584 584 10312 (radix_tree_node_alloc.constprop.0+0x89) > 1 192 192 10504 (__d_alloc+0x29) > 2 72 144 10648 (avc_alloc_node+0x27) > 2 64 128 10776 (percpu_ref_init+0x6a) > 1 64 64 10840 (memcg_list_lru_alloc+0x21a) > percpu: > 1 + 192 192 192 call_site=psi_cgroup_alloc+0x1e > 1 + 96 96 288 call_site=cgroup_rstat_init+0x5f > 2 12 24 312 call_site=percpu_ref_init+0x23 > 1 6 6 318 call_site=__percpu_counter_init+0x22 > > '+' -- to be accounted, > '~' -- partially accounted > > Signed-off-by: Vasily Averin Acked-by: Roman Gushchin