Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5dc3eb9d-229c-b086-9d1a-f695e94f8752@colorfullife.com>
Date:   Wed, 25 May 2022 21:26:20 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH] ipc: Remove dead code in perform_atomic_semop()
Content-Language: en-US
To:     Gautam Menghani <gautammenghani201@gmail.com>,
        akpm@linux-foundation.org, shakeelb@google.com,
        vasily.averin@linux.dev, mhocko@suse.com
Cc:     linux-kernel@vger.kernel.org,
        linux-kernel-mentees@lists.linuxfoundation.org,
        skhan@linuxfoundation.org
References: <20220524182244.42987-1-gautammenghani201@gmail.com>
From:   Manfred Spraul <manfred@colorfullife.com>
In-Reply-To: <20220524182244.42987-1-gautammenghani201@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 5/24/22 20:22, Gautam Menghani wrote:
> Remove the line which is dead code. Fixes the clang scan warning:
> warning: Value stored to 'result' is never read [deadcode.DeadStores]
>                  result = curr->semval;
>
> Signed-off-by: Gautam Menghani <gautammenghani201@gmail.com>
Reviewed-by: Manfred Spraul <manfred@colorfullife.com>
> ---
>   ipc/sem.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/ipc/sem.c b/ipc/sem.c
> index 0dbdb98fdf2d..156824bcda47 100644
> --- a/ipc/sem.c
> +++ b/ipc/sem.c
> @@ -766,7 +766,6 @@ static int perform_atomic_semop(struct sem_array *sma, struct sem_queue *q)
>   	for (sop = sops; sop < sops + nsops; sop++) {
>   		curr = &sma->sems[sop->sem_num];
>   		sem_op = sop->sem_op;
> -		result = curr->semval;
>   

A copy/paste mistake: The 1st loop in perform_atomic_semop() needs 
result - because it must check for overflows.

The 2nd loop doesn't need it.

>   		if (sop->sem_flg & SEM_UNDO) {
>   			int undo = un->semadj[sop->sem_num] - sem_op;

--

     Manfred