Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 25 May 2022 21:23:29 +0200
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     David Woodhouse <dwmw2@infradead.org>
Cc:     Geert Uytterhoeven <geert@linux-m68k.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        mark@msapiro.net, workflows@vger.kernel.org,
        Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        MTD Maling List <linux-mtd@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Miquel Raynal <miquel.raynal@bootlin.com>
Subject: Re: Getting rid of infradead.org - corrupted subjects
Message-ID: <20220525192329.iomxf2imkaymbjc3@pengutronix.de>
References: <b36280be-9993-9a78-0960-4094efeed1aa@linaro.org>
 <CAMuHMdWL93+r0cofwHKj1k-gUo9nk3OzUf6gtY68sK4JNibyNg@mail.gmail.com>
 <eb5ab9553c419b8259f5494664865597b6c5d4db.camel@infradead.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="tybjbooddzx3c3qw"
Content-Disposition: inline
In-Reply-To: <eb5ab9553c419b8259f5494664865597b6c5d4db.camel@infradead.org>
Precedence: bulk


--tybjbooddzx3c3qw
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, May 25, 2022 at 10:55:18AM +0100, David Woodhouse wrote:
> On Wed, 2022-05-25 at 10:34 +0200, Geert Uytterhoeven wrote:
> > CC dwmw2
>=20
> Thanks, Geert.
>=20
> > On Wed, May 25, 2022 at 10:07 AM Krzysztof Kozlowski
> > <krzysztof.kozlowski@linaro.org> wrote:
> >=20
> > > The address list is semi-random as I don't know whom to approach.
> > > Problem: infradead.org corrupts email subjects by changing:
> > > s/,/, /
>=20
> I found an old thread on mailman-users which appears to be claiming
> that it's just standard folding as described in RFC2822 =A72.2.3.
>=20
> https://mail.python.org/pipermail/mailman-users/2007-May/057119.html
>=20
> 2.2.3. Long Header Fields
>=20
>    Each header field is logically a single line of characters comprising
>    the field name, the colon, and the field body.  For convenience
>    however, and to deal with the 998/78 character limitations per line,
>    the field body portion of a header field can be split into a multiple
>    line representation; this is called "folding".  The general rule is
>    that wherever this standard allows for folding white space (not
>    simply WSP characters), a CRLF may be inserted before any WSP.  For
>    example, the header field:
>=20
>            Subject: This is a test
>=20
>    can be represented as:
>=20
>            Subject: This
>             is a test
>=20
> But this is folding at a *comma*, not at whitespace. The original
> subject line was (in a single line):
>=20
> Subject: [PATCH v2] dt-bindings: mtd: jedec,spi-nor: remove unneeded prop=
erties
>=20
> ... and Mailman 'folded' it in the wrong place to:
>=20
> Subject: [PATCH v2] dt-bindings: mtd: jedec,
>  spi-nor: remove unneeded properties
>=20
> That *isn't* proper folding because it didn't happen at a whitespace.
>=20
> I do need to upgrade to Mailman 3 at some point; I've been
> procrastinating on the basis that it "ain't broke". For the time being
> I've just disabled folding in MM2 with a trivial hack:
>=20
> --- Message.py.orig	2022-05-25 02:51:05.917145192 -0700
> +++ Message.py	2022-05-25 02:50:44.137142069 -0700
> @@ -49,7 +49,7 @@ class Generator(email.Generator.Generato
>         Headers will by default _not_ be folded in attachments.
>      """
>      def __init__(self, outfp, mangle_from_=3DTrue,
> -                 maxheaderlen=3D78, children_maxheaderlen=3D0):
> +                 maxheaderlen=3D0, children_maxheaderlen=3D0):
>          email.Generator.Generator.__init__(self, outfp,
>                  mangle_from_=3Dmangle_from_, maxheaderlen=3Dmaxheaderlen)
>          self.__children_maxheaderlen =3D children_maxheaderlen

For the record: Some time ago I debugged that myself, too and found an
equivalent change. So this looks good to me.

Best regards and thanks for caring,
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--tybjbooddzx3c3qw
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmKOgi4ACgkQwfwUeK3K
7AmUrgf9GplHRJVMfpm/l5d2OZURTa/slOVqodg2MpZPAwt8fWVpX+FQtESCPDQf
YSDFbyz8b0ytHlJRZ/FGjrSUHLXOpgAEqfofXJEYJul+Yt5GRAhpy2spNrP3fg93
O2+h0AnTRP2KK4ksMHccZOhzBbL/qGPwq2ekaa12HOGsQaAe+fQHZuCMGnW2RufU
QXlYmBO3m3QbuPCDyMZNSIf61LA8ogRq9sCmbjbL42RHwoA2l30psHJDLodyHVLu
qkzh6XfeMxfmGKC20/WW/uqH8/xarMcmMIsjjbIT+9NUPkrZ7D15hct+6PUmdjxV
B/LajT9mPt5p+tkbhZ/BxIXGY5iySA==
=MXTp
-----END PGP SIGNATURE-----

--tybjbooddzx3c3qw--