Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 24 May 2022 11:14:46 -0700
From:   Josh Poimboeuf <jpoimboe@kernel.org>
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     Linus Torvalds <torvalds@linux-foundation.org>,
        Ingo Molnar <mingo@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Borislav Petkov <bp@alien8.de>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [GIT PULL] objtool changes for v5.19
Message-ID: <20220524181446.rwa333ulf3qjbm2f@treble>
References: <You3JC/BOIyEnmQj@gmail.com>
 <Yoxucp7aUrCaV9uE@gmail.com>
 <Yox088fRrhh4grBX@gmail.com>
 <CAHk-=whRTihOdCij9MxpG433cB_9ZHhBeMVAVpAA5Bf2mdr5yA@mail.gmail.com>
 <Yo0fBWQEevzxttdZ@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <Yo0fBWQEevzxttdZ@hirez.programming.kicks-ass.net>
Precedence: bulk

On Tue, May 24, 2022 at 08:08:05PM +0200, Peter Zijlstra wrote:
> On Tue, May 24, 2022 at 10:53:40AM -0700, Linus Torvalds wrote:
> > On Mon, May 23, 2022 at 11:02 PM Ingo Molnar <mingo@kernel.org> wrote:
> > >
> > > Note that with your latest tree you'll get 3 new conflicts:
> > 
> > No problem, but the conflicts did make something clear: the objtool
> > code should just get rid of the "--uaccess" flag that is now
> > unconditional when CONFIG_X86_SMAP has been removed.
> > 
> > I didn't actually do that, and instead just did the mindless merge
> > conflict resolution, but it might be a good idea.
> 
> Yes, I think there is patch pending for that, but given the total merge
> pain we already had, I was waiting for all the dust to settle before
> taking it further.

Actually I think we should go the other direction by keeping '--uaccess'
and adding CONFIG_HAVE_UACCESS_VALIDATION or so.   The main point of
that objtool rewrite was to make all the features modular so other
arches could port them piecemeal.

-- 
Josh